[Android] Implement generic JSON results that match base/test/launcher.

[Android] Implement generic JSON results that match base/test/launcher.

BUG=428729
Committed: https://crrev.com/b8c4207c564baf7c01297852ef3ead70faac6a2d
Cr-Commit-Position: refs/heads/master@{#306207}

[jbudorick, 2014-11-24 19:26:51]

jbudorick@chromium.org changed reviewers:
+ klundberg@chromium.org, rnephew@chromium.org

[klundberg, 2014-11-25 18:59:49]

https://codereview.chromium.org/757683002/diff/40001/build/android/pylib/resu...
File build/android/pylib/results/json_results.py (right):

https://codereview.chromium.org/757683002/diff/40001/build/android/pylib/resu...
build/android/pylib/results/json_results.py:11: def
GenerateResultsDict(test_run_result):
I think it would be useful to have some unit tests for this to make sure that we
output what is expected. It doesn't have to be in this CL but maybe just add a
TODO to add unit tests? WDYT?

https://codereview.chromium.org/757683002/diff/40001/build/android/test_runne...
File build/android/test_runner.py (right):

https://codereview.chromium.org/757683002/diff/40001/build/android/test_runne...
build/android/test_runner.py:99: help='If set, will dump results in JSON form '
nit: Maybe change "form" to "format"?
But I'm not the native English speaker :-)

[jbudorick, 2014-11-25 23:32:18]

https://codereview.chromium.org/757683002/diff/40001/build/android/pylib/resu...
File build/android/pylib/results/json_results.py (right):

https://codereview.chromium.org/757683002/diff/40001/build/android/pylib/resu...
build/android/pylib/results/json_results.py:11: def
GenerateResultsDict(test_run_result):
On 2014/11/25 18:59:49, klundberg wrote:
> I think it would be useful to have some unit tests for this to make sure that
we
> output what is expected. It doesn't have to be in this CL but maybe just add a
> TODO to add unit tests? WDYT?

Sounds like a good idea to me. Tests added.

https://codereview.chromium.org/757683002/diff/40001/build/android/test_runne...
File build/android/test_runner.py (right):

https://codereview.chromium.org/757683002/diff/40001/build/android/test_runne...
build/android/test_runner.py:99: help='If set, will dump results in JSON form '
On 2014/11/25 18:59:49, klundberg wrote:
> nit: Maybe change "form" to "format"?
> But I'm not the native English speaker :-)

Done.

[klundberg, 2014-12-01 15:37:46]

lgtm

Thanks for adding the tests, John!

[jbudorick, 2014-12-01 15:39:54]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-12-01 15:40:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/757683002/60001

[commit-bot: I haz the power, 2014-12-01 15:45:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-01 15:45:01]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbudorick, 2014-12-01 16:10:24]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-12-01 16:11:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/757683002/80001

[commit-bot: I haz the power, 2014-12-01 18:08:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-12-01 18:08:46]

Patchset 5 (id:??) landed as
https://crrev.com/b8c4207c564baf7c01297852ef3ead70faac6a2d
Cr-Commit-Position: refs/heads/master@{#306207}