Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 757633002: Remove android-framework-only unused parameter. (Closed)

Created:
6 years ago by scroggo
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove android-framework-only unused parameter. Allows -Werror=unused-parameter to build on android framework. Committed: https://skia.googlesource.com/skia/+/01c412e40ac4caa8df073b5235e22deb6f380b2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkShader.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
scroggo
6 years ago (2014-11-24 16:52:30 UTC) #2
scroggo
Adding reed@ since this is a public header.
6 years ago (2014-11-24 16:53:02 UTC) #4
reed1
lgtm
6 years ago (2014-11-24 16:53:32 UTC) #5
robertphillips
lgtm
6 years ago (2014-11-24 16:54:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757633002/1
6 years ago (2014-11-24 16:55:02 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-24 17:05:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/01c412e40ac4caa8df073b5235e22deb6f380b2b

Powered by Google App Engine
This is Rietveld 408576698