Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 757563003: restore old convention of asserting refcnt==1 in destructor (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

restore old convention of asserting refcnt==1 in destructor BUG=skia: Committed: https://skia.googlesource.com/skia/+/3c850c561fcad1ac35bff4ec2875a40ef2309148

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M include/core/SkRefCnt.h View 1 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
reed1
6 years ago (2014-11-24 21:57:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757563003/1
6 years ago (2014-11-24 21:57:44 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-11-24 21:57:45 UTC) #5
mtklein
lgtm
6 years ago (2014-11-24 21:58:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757563003/20001
6 years ago (2014-11-24 22:02:43 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-24 22:13:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3c850c561fcad1ac35bff4ec2875a40ef2309148

Powered by Google App Engine
This is Rietveld 408576698