Add SOURCE_TEST.

Add SOURCE_TEST.

See https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/AppLaunchParams/chromium-dev/uPckpeYSlNA/bwfwZAtbEEkJ
for a discussion of what I'm trying to do, and https://codereview.chromium.org/771003002 for more context of how I'm going to use
this to achieve it.

Committed: https://crrev.com/416c074ced7d016b0502330941eeeca21cc30b82
Cr-Commit-Position: refs/heads/master@{#308115}

[Jamie, 2014-12-02 21:48:11]

jamiewalch@chromium.org changed reviewers:
+ benwells@chromium.org, cylee@chromium.org

[Jamie, 2014-12-02 21:48:12]

jamiewalch@chromium.org changed required reviewers:
+ benwells@chromium.org

[Jamie, 2014-12-02 21:48:12]

benwells: PTAL.
cylee: FYI.

[benwells, 2014-12-02 22:16:41]

Seems like a good idea. Are you planning to update all the browser tests that
create launch parameters?

[Jamie, 2014-12-02 23:38:05]

Patchset #2 (id:20001) has been deleted

[Jamie, 2014-12-02 23:45:41]

On 2014/12/02 22:16:41, benwells wrote:
> Seems like a good idea. Are you planning to update all the browser tests that
> create launch parameters?

Done. I've only updated the uses I could find that were obviously browser tests
by looking at the filenames. There are still a few places using
SOURCE_UNTRACKED:

  chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
  chrome/browser/extensions/extension_apitest.cc
  extensions/shell/browser/shell_extension_system.cc

The first two look like tests, and I could easily rename the source to something
like SOURCE_TEST so that they can be included. Or I could add an explicit
SOURCE_API_TEST if there's any value in keeping them distinct.

If there are other browser tests lurking that need to be updated, I don't know
how to find them.

[benwells, 2014-12-03 00:21:56]

On 2014/12/02 23:45:41, Jamie wrote:
> On 2014/12/02 22:16:41, benwells wrote:
> > Seems like a good idea. Are you planning to update all the browser tests
that
> > create launch parameters?
> 
> Done. I've only updated the uses I could find that were obviously browser
tests
> by looking at the filenames. There are still a few places using
> SOURCE_UNTRACKED:
> 
>   chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
>   chrome/browser/extensions/extension_apitest.cc
>   extensions/shell/browser/shell_extension_system.cc
> 
> The first two look like tests, and I could easily rename the source to
something
> like SOURCE_TEST so that they can be included. Or I could add an explicit
> SOURCE_API_TEST if there's any value in keeping them distinct.
> 
> If there are other browser tests lurking that need to be updated, I don't know
> how to find them.

I believe the _apitests are in fact browser tests, but I like your suggestion of
just making this SOURCE_TEST. The distinction between test types seems academic.

[cylee1, 2014-12-03 15:20:57]

lgtm

https://codereview.chromium.org/757433004/diff/40001/extensions/common/consta...
File extensions/common/constants.h (right):

https://codereview.chromium.org/757433004/diff/40001/extensions/common/consta...
extensions/common/constants.h:115: SOURCE_UNTRACKED = 0,  // Should be used in
test.
You can remove the comment.

[Jamie, 2014-12-04 01:06:53]

Renamed as per Ben's suggestion and updated the two remaining tests.

PTAL.

https://codereview.chromium.org/757433004/diff/40001/extensions/common/consta...
File extensions/common/constants.h (right):

https://codereview.chromium.org/757433004/diff/40001/extensions/common/consta...
extensions/common/constants.h:115: SOURCE_UNTRACKED = 0,  // Should be used in
test.
On 2014/12/03 15:20:57, cylee1 wrote:
> You can remove the comment.

Done.

[benwells, 2014-12-04 03:44:47]

https://codereview.chromium.org/757433004/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_local_account_browsertest.cc (right):

https://codereview.chromium.org/757433004/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_local_account_browsertest.cc:1341:
extensions::SOURCE_BROWSER_TEST));
This (and some others) still say BROWSER_TEST.

[Jamie, 2014-12-04 18:10:01]

PTAL

https://codereview.chromium.org/757433004/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_local_account_browsertest.cc (right):

https://codereview.chromium.org/757433004/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_local_account_browsertest.cc:1341:
extensions::SOURCE_BROWSER_TEST));
On 2014/12/04 03:44:47, benwells wrote:
> This (and some others) still say BROWSER_TEST.

Done.

[Jamie, 2014-12-08 21:03:53]

Ping benwells.

[benwells, 2014-12-09 06:53:50]

lgtm

[Jamie, 2014-12-09 18:21:22]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2014-12-09 18:22:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/757433004/80001

[commit-bot: I haz the power, 2014-12-09 18:29:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-09 18:29:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jamie, 2014-12-09 20:43:26]

jamiewalch@chromium.org changed reviewers:
+ bartfab@chromium.org, dmichael@chromium.org, jar@chromium.org,
sky@chromium.org

[Jamie, 2014-12-09 20:43:27]

Additional OWNERS, ptal.

[dmichael (off chromium), 2014-12-09 20:45:21]

ppapi lgtm

[Jamie, 2014-12-11 00:59:33]

Ping sky,jar & bartfab

[jar (doing other things), 2014-12-11 02:06:56]

jar@chromium.org changed reviewers:
+ asvitkine@chromium.org
- jar@chromium.org

[jar (doing other things), 2014-12-11 02:06:57]

+asvitkine for histograms.xml

[sky, 2014-12-11 15:27:15]

pro-tip: clearly indicate what you want your reviewers to review, otherwise they
may ignore.

[Alexei Svitkine (slow), 2014-12-11 15:40:07]

histograms lgtm

[Jamie, 2014-12-11 18:31:53]

Apologies; I thought it would be clear from my OWNERS comment, but I guess a lot
of you guys are owners of lots of different things :)

To be explicit:

bartfab: chrome/browser/chromeos/policy & chrome/browser/policy
sky: chrome/browser/ui

[sky, 2014-12-11 19:20:15]

c/b/ui LGTM

[bartfab (slow), 2014-12-12 11:50:09]

policy lgtm

[Jamie, 2014-12-12 17:41:33]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2014-12-12 17:42:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/757433004/80001

[commit-bot: I haz the power, 2014-12-12 17:46:19]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2014-12-12 17:47:16]

Patchset 4 (id:??) landed as
https://crrev.com/416c074ced7d016b0502330941eeeca21cc30b82
Cr-Commit-Position: refs/heads/master@{#308115}