Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 757313002: clang-format/java: Allow one-line empty functions. (Closed)

Created:
6 years ago by Nico
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

clang-format/java: Allow one-line empty functions. Before: void f() { } int g() { return 0; } Now: void f() {} int g() { return 0; } Do this by removing the explicit setting for AllowShortFunctionsOnSingleLine, as of recently [1] it defaults to "Empty" for Java, a new setting that does what we want. Chromium style used to unconditionally override AllowShortFunctionsOnSingleLine to the wrong thing, so I taught clang-format to not do that for Java files, and while there also made -style=Chromium do the right thing for most of the settings [2], so remove most explicit settings from this file. Except for AllowShortFunctionsOnSingleLine, this doesn't change behavior. 1: http://llvm.org/viewvc/llvm-project?view=revision&revision=222819 2: http://llvm.org/viewvc/llvm-project?view=revision&revision=222839 BUG=429372 NOTRY=true Committed: https://crrev.com/f714c2a03b058bf83fe6d86816dcdcd0a5b212e0 Cr-Commit-Position: refs/heads/master@{#305830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M .clang-format View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
Make sure to grab the new binary from my home dir, else this patch will ...
6 years ago (2014-11-26 16:54:35 UTC) #2
aurimas (slooooooooow)
lgtm
6 years ago (2014-11-26 18:00:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757313002/1
6 years ago (2014-11-26 18:01:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-26 18:03:24 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-26 18:04:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f714c2a03b058bf83fe6d86816dcdcd0a5b212e0
Cr-Commit-Position: refs/heads/master@{#305830}

Powered by Google App Engine
This is Rietveld 408576698