[NaCl SDK] nacl_io: wrap kernel intercept calls in a macro

[NaCl SDK] nacl_io: wrap kernel intercept calls in a macro

This reduces duplciation and allows for hooks (e.g. tracing)
at the kernel proxy boundary.

R=binji

Committed: https://crrev.com/7f7a13ddc8e97fdeef6804069e72499175a29dfb
Cr-Commit-Position: refs/heads/master@{#311372}

[binji, 2014-12-02 18:31:56]

https://codereview.chromium.org/757293005/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/kernel_intercept.cc (right):

https://codereview.chromium.org/757293005/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/kernel_intercept.cc:37: #define
KP_CALL(METHOD, ARGS) \
I like this in general, but I don't like that you've only traced some of the
calls; I think this could be a bit confusing if you were actually debugging the
kernel intercept layer ("why didn't this print? Is it because it wasn't called,
or because it isn't traced?")

Ultimately I think tracing will be much nicer if it printed args too, but that
can happen in a later CL.

[Sam Clegg, 2015-01-13 18:46:29]

https://codereview.chromium.org/757293005/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/kernel_intercept.cc (right):

https://codereview.chromium.org/757293005/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/kernel_intercept.cc:37: #define
KP_CALL(METHOD, ARGS) \
On 2014/12/02 18:31:56, binji wrote:
> I like this in general, but I don't like that you've only traced some of the
> calls; I think this could be a bit confusing if you were actually debugging
the
> kernel intercept layer ("why didn't this print? Is it because it wasn't
called,
> or because it isn't traced?")
> 
> Ultimately I think tracing will be much nicer if it printed args too, but that
> can happen in a later CL.

Done.

[binji, 2015-01-14 00:33:12]

nice, lgtm

[Sam Clegg, 2015-01-14 00:33:59]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-01-14 00:35:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/757293005/40001

[commit-bot: I haz the power, 2015-01-14 00:39:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-14 00:40:07]

Patchset 3 (id:??) landed as
https://crrev.com/7f7a13ddc8e97fdeef6804069e72499175a29dfb
Cr-Commit-Position: refs/heads/master@{#311372}