tools/perf/benchmarks/page_cycler.py - Issue 757233006: Disable moz, dhtml, and roborhornet_pro benchmarks on all OSes except Chrome OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 757233006: Disable moz, dhtml, and roborhornet_pro benchmarks on all OSes except Chrome OS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/page_cycler.py

diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py

index 73c1ad4b6213d588310a61c9d240e56610dc69be..46eb6d46510d375dea7708c2577edfd4a90f3f6e 100644

--- a/tools/perf/benchmarks/page_cycler.py

+++ b/tools/perf/benchmarks/page_cycler.py

@@ -32,6 +32,9 @@ class _PageCycler(benchmark.Benchmark):

report_speed_index = options.report_speed_index)

+# This is an old page set, we intend to remove it after Chrome OS

+# extends telemetry support to run more modern benchmarks.

tonyg 2014/12/05 21:31:20 Nit: this sentence doesn't flow quite right. Maybe

sullivan 2014/12/05 21:43:42 Done.

+@benchmark.Enabled('chromeos')

class PageCyclerDhtml(_PageCycler):

page_set = page_sets.DhtmlPageSet

@@ -63,6 +66,9 @@ class PageCyclerMorejs(_PageCycler):

page_set = page_sets.MorejsPageSet

+# This is an old page set, we intend to remove it after Chrome OS

+# extends telemetry support to run more modern benchmarks.

+@benchmark.Enabled('chromeos')

class PageCyclerMoz(_PageCycler):

page_set = page_sets.MozPageSet

« no previous file with comments | « no previous file | tools/perf/benchmarks/robohornet_pro.py » ('j') | tools/perf/benchmarks/robohornet_pro.py » ('J')