Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 757233006: Disable moz, dhtml, and roborhornet_pro benchmarks on all OSes except Chrome OS (Closed)

Created:
6 years ago by sullivan
Modified:
6 years ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, llozano, lafeenstra, cmtice
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable moz, dhtml, and roborhornet_pro benchmarks on all OSes except Chrome OS BUG= Committed: https://crrev.com/2a5f990ab02816573c4c58f2425b92574eba8c2c Cr-Commit-Position: refs/heads/master@{#307103}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Cleaned up comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M tools/perf/benchmarks/page_cycler.py View 1 2 chunks +6 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
sullivan
lafeenstra, llozano, cmtice: Is there a bug I can link about supporting the new benchmarks?
6 years ago (2014-12-05 20:46:26 UTC) #2
tonyg
lgtm https://codereview.chromium.org/757233006/diff/1/tools/perf/benchmarks/page_cycler.py File tools/perf/benchmarks/page_cycler.py (right): https://codereview.chromium.org/757233006/diff/1/tools/perf/benchmarks/page_cycler.py#newcode36 tools/perf/benchmarks/page_cycler.py:36: # extends telemetry support to run more modern ...
6 years ago (2014-12-05 21:31:20 UTC) #3
sullivan
https://codereview.chromium.org/757233006/diff/1/tools/perf/benchmarks/page_cycler.py File tools/perf/benchmarks/page_cycler.py (right): https://codereview.chromium.org/757233006/diff/1/tools/perf/benchmarks/page_cycler.py#newcode36 tools/perf/benchmarks/page_cycler.py:36: # extends telemetry support to run more modern benchmarks. ...
6 years ago (2014-12-05 21:43:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757233006/20001
6 years ago (2014-12-05 21:44:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-05 23:13:33 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-05 23:14:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a5f990ab02816573c4c58f2425b92574eba8c2c
Cr-Commit-Position: refs/heads/master@{#307103}

Powered by Google App Engine
This is Rietveld 408576698