Issue 757143004: Remove m_layerTreeView from WebViewImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 757143004: Remove m_layerTreeView from WebViewImpl. (Closed)

Created:
6 years ago by ojan

Modified:
6 years ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove m_layerTreeView from WebViewImpl. It's always null now. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6d88f117fc7c931ece6ff0403d78e45bc9f17f38

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -320 lines)			Patch
M	sky/engine/core/dom/Document.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	2 chunks	+0 lines, -19 lines	0 comments	Download
M	sky/engine/core/loader/FrameLoaderClient.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/page/ChromeClient.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/public/platform/WebLayerTreeView.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	sky/engine/public/web/WebSettings.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/public/web/WebWidget.h	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	sky/engine/web/ChromeClientImpl.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/web/ChromeClientImpl.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/web/FrameLoaderClientImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/FrameLoaderClientImpl.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	sky/engine/web/GraphicsLayerFactoryChromium.h	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	sky/engine/web/GraphicsLayerFactoryChromium.cpp	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	sky/engine/web/WebSettingsImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/WebSettingsImpl.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.h	View	8 chunks	+0 lines, -20 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View	19 chunks	+5 lines, -215 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ojan

6 years ago (2014-11-26 03:54:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6d88f117fc7c931ece6ff0403d78e45bc9f17f38.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages