Issue 757113002: ExcServerVariants test: use constructors to initialize test structures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 757113002: ExcServerVariants test: use constructors to initialize test structures (Closed)

Created:
6 years ago by Mark Mentovai

Modified:
6 years ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

ExcServerVariants test: use constructors to initialize test structures. Previously, test structures were initialized with InitializeForTesting() methods. A related code review suggested making these into constructors. https://codereview.chromium.org/754123002/diff/40001/util/mach/child_port_server_test.cc#newcode53 This also cleans up the definitions of some structures that can simply inherit from existing structures defined in system headers. TEST=util_test ExcServerVariants.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/de5a6cdd6f042aa78fc53e26ebc6d70be3ef2bd0

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -95 lines)			Patch
	M	util/mach/child_port_server_test.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
	M	util/mach/exc_server_variants_test.cc	View	1	20 chunks	+74 lines, -90 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

6 years ago (2014-11-25 20:06:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
de5a6cdd6f042aa78fc53e26ebc6d70be3ef2bd0 (presubmit successful).