Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: build/android.gypi

Issue 757103003: Android ARM: enable PIE. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android.gypi
diff --git a/build/android.gypi b/build/android.gypi
index 627dcc2678246e0af2851239635a747aae0654c4..b7fc7147e8d9a992310bdbe02994643c02db5d45 100644
--- a/build/android.gypi
+++ b/build/android.gypi
@@ -215,8 +215,7 @@
'-fno-stack-protector',
],
}],
- ['target_arch=="arm64" or target_arch=="x64"', {
- # TODO(ulan): Enable PIE for other architectures (crbug.com/373219).
+ ['target_arch=="arm" or target_arch=="arm64" or target_arch=="x64"', {
'cflags': [
'-fPIE',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698