content/browser/web_contents/web_contents_impl.h - Issue 757033005: Make tab audible and muted states and cause available for an extension API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 757033005: Make tab audible and muted states and cause available for an extension API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improve naming/capitalization for muted toggle strings; remove audible/muted event-listener code fr… Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/web_contents_audio_input_stream.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 665695d83390938503db2fe74338ad52b1151be5..89420e5f5dd3d25b6f4590fd654010000887a659 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -247,7 +247,8 @@ class CONTENT_EXPORT WebContentsImpl

void DecrementCapturerCount() override;

int GetCapturerCount() const override;

bool IsAudioMuted() const override;

- void SetAudioMuted(bool mute) override;

+ void SetAudioMuted(bool muted, const std::string& cause) override;

+ const std::string& GetAudioMutedCause() const override;

bool IsCrashed() const override;

void SetIsCrashed(base::TerminationStatus status, int error_code) override;

base::TerminationStatus GetCrashedStatus() const override;

@@ -1076,6 +1077,9 @@ class CONTENT_EXPORT WebContentsImpl

// to modify the blank page. Always false after the first commit.

bool has_accessed_initial_document_;

+ // Source (initial, user, capture, extensionid) for the tab's muted state

+ std::string mutedToggleCause_;

miu 2014/12/20 03:42:38 style (underscores, not camel case): This should b

// Data for misc internal state ----------------------------------------------

// When > 0, the WebContents is currently being captured (e.g., for