net/socket/ssl_client_socket_unittest.cc - Issue 757033004: Do not use HTTP/2 without adequate security.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_unittest.cc

Issue 757033004: Do not use HTTP/2 without adequate security. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do not leave out TLS version check. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_unittest.cc

diff --git a/net/socket/ssl_client_socket_unittest.cc b/net/socket/ssl_client_socket_unittest.cc

index d650f627df44889770ff8c20da00476c2f83cfb8..d14f1fdbb1df0c1ed68b40b68f6773b72e8380f1 100644

--- a/net/socket/ssl_client_socket_unittest.cc

+++ b/net/socket/ssl_client_socket_unittest.cc

@@ -2356,7 +2356,7 @@ TEST(SSLClientSocket, SerializeNextProtos) {

next_protos.push_back(kProtoHTTP11);

next_protos.push_back(kProtoSPDY31);

static std::vector<uint8_t> serialized =

- SSLClientSocket::SerializeNextProtos(next_protos);

+ SSLClientSocket::SerializeNextProtos(next_protos, true);

ASSERT_EQ(18u, serialized.size());

EXPECT_EQ(8, serialized[0]); // length("http/1.1")

EXPECT_EQ('h', serialized[1]);