Do not use HTTP/2 without adequate security.

net/socket/ssl_client_socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_H_
 #define NET_SOCKET_SSL_CLIENT_SOCKET_H_
 
 #include <string>
 
 #include "base/gtest_prod_util.h"
@@ skipping 191 matching lines @@
       bool supports_ecc);
 
   // Records ConnectionType histograms for a successful SSL connection.
   static void RecordConnectionTypeMetrics(int ssl_version);
 
   // Returns whether TLS channel ID is enabled.
   static bool IsChannelIDEnabled(
       const SSLConfig& ssl_config,
       ChannelIDService* channel_id_service);
 
+  // Determine if there is at least one enabled cipher suite and TLS version
+  // that is up to Section 9.2 of the HTTP/2 specification.  Note that the

[Ryan Hamilton, 2014/12/10 21:11:41]

s/that is up to/that satisfies/

[Bence, 2014/12/11 16:50:49]

Done.

+  // server might still pick an inadequate cipher suite or TLS version.
+  static bool IsSecurityAdequateForHTTP2(
+      const SSLConfig& ssl_config,
+      const std::vector<uint16>& cipher_suites);
+
   // Serializes |next_protos| in the wire format for ALPN: protocols are listed
-  // in order, each prefixed by a one-byte length.
+  // in order, each prefixed by a one-byte length.  Only advertises HTTP2 if
+  // adequate cipher suites and TLS are also advertised.

[Ryan Hamilton, 2014/12/10 21:11:41]

Instead of talking about adequate cipher suites and TLS versions, I would just
refer to |advertise_http2|. Or possibly consider reversing the polarity and
making it |exclude_http2|. As currently written, if advertise_http2 = true, I
might expect that that *forces* http2 (which it doesn't do obviously).

[Bence, 2014/12/11 16:50:49]

I decided against reversing polarity, because I do not want a negation like
SerializeNextProtos(!IsSecurityAdequate), not do I like reversing the polarity
of IsSecurityAdequate.

Done.

   static std::vector<uint8_t> SerializeNextProtos(
-      const std::vector<std::string>& next_protos);
+      const std::vector<std::string>& next_protos,
+      bool advertise_http2);
 
   // For unit testing only.
   // Returns the unverified certificate chain as presented by server.
   // Note that chain may be different than the verified chain returned by
   // StreamSocket::GetSSLInfo().
   virtual scoped_refptr<X509Certificate> GetUnverifiedServerCertificateChain()
       const = 0;
 
  private:
   // For signed_cert_timestamps_received_ and stapled_ocsp_response_received_.
@@ skipping 18 matching lines @@
   bool signed_cert_timestamps_received_;
   // True if a stapled OCSP response was received.
   bool stapled_ocsp_response_received_;
   // Protocol negotiation extension used.
   SSLNegotiationExtension negotiation_extension_;
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_CLIENT_SOCKET_H_