Do not use HTTP/2 without adequate security.

net/socket/ssl_client_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/ssl_client_socket.h"
 
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/strings/string_util.h"
 #include "crypto/ec_private_key.h"
 #include "net/base/connection_type_histograms.h"
 #include "net/base/host_port_pair.h"
 #include "net/ssl/channel_id_service.h"
+#include "net/ssl/ssl_cipher_suite_names.h"
 #include "net/ssl/ssl_config_service.h"
 #include "net/ssl/ssl_connection_status_flags.h"
 
 namespace net {
 
 SSLClientSocket::SSLClientSocket()
     : was_npn_negotiated_(false),
       was_spdy_negotiated_(false),
       protocol_negotiated_(kProtoUnknown),
       channel_id_sent_(false),
@@ skipping 203 matching lines @@
   }
   if (!channel_id_service->IsSystemTimeValid()) {
     DVLOG(1) << "System time is not within the supported range for certificate "
                 "generation, not enabling channel ID.";
     return false;
   }
   return true;
 }
 
 // static
+bool IsSecurityAdequateForHTTP2(const SSLConfig& ssl_config,
+                                const std::vector<uint16>& cipher_suites) {
+  if (ssl_config.version_max < SSL_PROTOCOL_VERSION_TLS1_2) {
+    return false;
+  }
+  for (std::vector<uint16>::const_iterator it = cipher_suites.begin();
+       it != cipher_suites.end(); ++it) {
+    if (IsSecureTLSCipherSuite(*it)) {
+      return true;
+    }
+  }
+  return false;
+}
+
+// static
 std::vector<uint8_t> SSLClientSocket::SerializeNextProtos(
-    const std::vector<std::string>& next_protos) {
+    const std::vector<std::string>& next_protos,
+    bool advertise_http2) {
   // Do a first pass to determine the total length.
   size_t wire_length = 0;
   for (std::vector<std::string>::const_iterator i = next_protos.begin();
        i != next_protos.end(); ++i) {
     if (i->size() > 255) {
       LOG(WARNING) << "Ignoring overlong NPN/ALPN protocol: " << *i;
       continue;
     }
     if (i->size() == 0) {
       LOG(WARNING) << "Ignoring empty NPN/ALPN protocol";
       continue;
     }
+    if (!advertise_http2) {
+      const NextProto proto = NextProtoFromString(*i);
+      if (kProtoSPDY4MinimumVersion <= proto &&
+          proto <= kProtoSPDY4MaximumVersion) {
+        continue;
+      }
+    }
     wire_length += i->size();
     wire_length++;
   }
 
   // Allocate memory for the result and fill it in.
   std::vector<uint8_t> wire_protos;
   wire_protos.reserve(wire_length);
   for (std::vector<std::string>::const_iterator i = next_protos.begin();
        i != next_protos.end(); i++) {
     if (i->size() == 0 || i->size() > 255)
       continue;
+    if (!advertise_http2) {
+      const NextProto proto = NextProtoFromString(*i);
+      if (kProtoSPDY4MinimumVersion <= proto &&
+          proto <= kProtoSPDY4MaximumVersion) {
+        continue;
+      }
+    }
     wire_protos.push_back(i->size());
     wire_protos.resize(wire_protos.size() + i->size());
     memcpy(&wire_protos[wire_protos.size() - i->size()],
            i->data(), i->size());
   }
   DCHECK_EQ(wire_protos.size(), wire_length);
 
   return wire_protos;
 }
 
@@ skipping 17 matching lines @@
     } else {
       sample += 500;
     }
   } else {
     DCHECK_EQ(kExtensionALPN, negotiation_extension_);
   }
   UMA_HISTOGRAM_SPARSE_SLOWLY("Net.SSLProtocolNegotiation", sample);
 }
 
 }  // namespace net