Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: tests/corelib/iterable_to_list_test.dart

Issue 75703002: Revert "This change makes it easier to put type parameters on JavaScript Arrays." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/value_range_test.dart ('k') | tests/utils/dummy_compiler_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/iterable_to_list_test.dart
diff --git a/tests/corelib/iterable_to_list_test.dart b/tests/corelib/iterable_to_list_test.dart
index 3ee443a0a7895a57d03ca1e4b8c23490cadbfd7b..6a5c454017c9e81827a54832ec56ebf5ff439ba8 100644
--- a/tests/corelib/iterable_to_list_test.dart
+++ b/tests/corelib/iterable_to_list_test.dart
@@ -4,12 +4,6 @@
import "package:expect/expect.dart";
-dynamicCheck(input, {isInt, isString}) {
- var copy = input.toList();
- Expect.isTrue(isInt == copy is List<int>);
- Expect.isTrue(isString == copy is List<String>);
-}
-
main() {
List<int> list1 = <int>[1, 2, 3];
List<int> list2 = const <int>[4, 5];
@@ -29,21 +23,18 @@ main() {
Expect.isTrue(listCopy is List<int>);
Expect.isFalse(listCopy is List<String>);
Expect.isFalse(identical(list1, listCopy));
- dynamicCheck(list1, isInt: true, isString: false);
listCopy = list2.toList();
Expect.listEquals(list2, listCopy);
Expect.isTrue(listCopy is List<int>);
Expect.isFalse(listCopy is List<String>);
Expect.isFalse(identical(list2, listCopy));
- dynamicCheck(list2, isInt: true, isString: false);
listCopy = list3.toList();
Expect.listEquals(list3, listCopy);
Expect.isTrue(listCopy is List<String>);
Expect.isFalse(listCopy is List<int>);
Expect.isFalse(identical(list3, listCopy));
- dynamicCheck(list3, isInt: false, isString: true);
listCopy = set1.toList();
Expect.equals(3, listCopy.length);
@@ -52,7 +43,6 @@ main() {
Expect.isTrue(listCopy.contains(13));
Expect.isTrue(listCopy is List<int>);
Expect.isFalse(listCopy is List<String>);
- dynamicCheck(set1, isInt: true, isString: false);
listCopy = set2.toList();
Expect.equals(3, listCopy.length);
@@ -61,11 +51,9 @@ main() {
Expect.isTrue(listCopy.contains("toto"));
Expect.isTrue(listCopy is List<String>);
Expect.isFalse(listCopy is List<int>);
- dynamicCheck(set2, isInt: false, isString: true);
listCopy = set3.toList();
Expect.isTrue(listCopy.isEmpty);
Expect.isTrue(listCopy is List<int>);
Expect.isTrue(listCopy is List<String>);
- dynamicCheck(set3, isInt: true, isString: true);
}
« no previous file with comments | « tests/compiler/dart2js/value_range_test.dart ('k') | tests/utils/dummy_compiler_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698