Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4217)

Unified Diff: build/config/android/rules.gni

Issue 757023003: GN + Android: quick fix for stale assets in Android APKs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 938a09005afdfc44727f67b9fdfe9976aa78d8f2..dd14f931791020b9fa05f321447203c10053b29b 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -1212,17 +1212,24 @@ template("android_apk") {
version_name = invoker.version_name
}
- if (defined(invoker.asset_location)) {
- asset_location = invoker.asset_location
- }
-
keystore_name = _keystore_name
keystore_path = _keystore_path
keystore_password = _keystore_password
+ deps = []
+ if (defined(invoker.asset_location)) {
+ asset_location = invoker.asset_location
+ # We don't know the exact dependencies that create the assets in
+ # |asset_location|; we depend on all caller deps until a better solution
+ # is figured out (http://crbug.com/433330).
+ if (defined(invoker.deps)) {
+ deps += invoker.deps
+ }
+ }
+
if (_native_libs != []) {
native_libs_dir = _native_libs_dir
- deps = [":${_template_name}__prepare_native"]
+ deps += [":${_template_name}__prepare_native"]
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698