Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2026)

Issue 756913002: DevTools: Rename WI.Color's toString(format) -> asString(format) (Closed)

Created:
6 years ago by apavlov
Modified:
6 years ago
Reviewers:
eustas
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Rename WI.Color's toString(format) -> asString(format) toString(format) is an override of the Object's method with a different signature, which is an error. R=eustas NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185936

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M LayoutTests/inspector/color.html View 1 2 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-invalid-color-values.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/common/Color.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/MetricsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/Spectrum.js View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/screencast/ScreencastView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/CountersGraph.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
apavlov
6 years ago (2014-11-25 08:44:58 UTC) #1
eustas
lgtm
6 years ago (2014-11-25 08:58:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756913002/20001
6 years ago (2014-11-25 09:12:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756913002/20001
6 years ago (2014-11-25 10:29:08 UTC) #9
commit-bot: I haz the power
6 years ago (2014-11-25 10:29:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185936

Powered by Google App Engine
This is Rietveld 408576698