Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 756903003: Fixed race condition in HBranch::observed_input_representation. (Closed)

Created:
6 years ago by Sven Panne
Modified:
6 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fixed race condition in HBranch::observed_input_representation. Non-numeric static local variables are not thread-safe, and the case at hand was a premature optimization anyway: The generated code for the check in question is exactly the same when unfolded. BUG=chromium:420483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M src/hydrogen-instructions.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sven Panne
6 years ago (2014-11-25 13:21:34 UTC) #2
Jakob Kummerow
LGTM. I guess as an alternative you could just s/static //. Up to you.
6 years ago (2014-11-25 13:45:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756903003/1
6 years ago (2014-11-25 13:51:01 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-25 14:47:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698