Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 756743003: More changes to WebLocalFrame for Autofill OOPIF. (Closed)

Created:
6 years ago by Evan Stade
Modified:
6 years ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

More changes to WebLocalFrame for Autofill OOPIF. First patch was: https://codereview.chromium.org/737853002/ Turns out we also need to expose WebLocalFrame::autofillAgent() in order to port existing tests. BUG=425756, 400186 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/web/WebLocalFrameImpl.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebLocalFrame.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Evan Stade
6 years ago (2014-11-25 00:06:53 UTC) #2
Mike West
LGTM.
6 years ago (2014-11-25 10:31:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756743003/1
6 years ago (2014-11-25 16:38:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/38408)
6 years ago (2014-11-25 18:52:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756743003/1
6 years ago (2014-11-25 20:29:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/38438)
6 years ago (2014-11-25 22:41:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756743003/1
6 years ago (2014-11-25 23:11:27 UTC) #13
commit-bot: I haz the power
6 years ago (2014-11-26 01:08:52 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185989

Powered by Google App Engine
This is Rietveld 408576698