Switch in box ChromeVox to use new background page.

Switch in box ChromeVox to use new background page.

Depends on
https://codereview.chromium.org/743273002/

This enables ChromeVox to use the new Automation extension API based background page for the chrome of Chrome.

TEST=interactive_ui_tests *SpokenFeedbackTest.*

Committed: https://crrev.com/bae9fa8fefa8b21115d049ce6562480b0f892969
Cr-Commit-Position: refs/heads/master@{#307110}

[David Tseng, 2014-11-24 21:36:10]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org, plundblad@chromium.org

[David Tseng, 2014-11-26 23:08:58]

This cl is the minimal change to actually perform the flip to ChromeVox Next
including passing SpokenFeedbackTest modifications. One test I couldn't get to
pass; I spent a lot of time fiddling with these tests and they seem more brittle
now that small changes in output formatting cause hard to debug breaks in the
tests especially pattern matching expectations. I don't want these tests to be a
roadblock to changes but also do find them useful. Thoughts welcome on that and
on this cl.

[dmazzoni, 2014-11-29 08:03:59]

lgtm

https://codereview.chromium.org/756713003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
(right):

https://codereview.chromium.org/756713003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:267:
"about:blank about:blank*Toolbar toolbar Reload Button"));
Why is about:blank there twice? How about the shortest possible string that
applies to this specific test, maybe:

"*Toolbar toolbar Reload Button".

https://codereview.chromium.org/756713003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:341: if
(MatchPattern(utterance, "*Bluetooth* Button"))
BTW, are you sure you want to remove this comma between the name and the role?
Maybe it'd be better to leave the comma there.

https://codereview.chromium.org/756713003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:540:
"about:blank about:blank*Toolbar toolbar Reload Button"));
same as above

[David Tseng, 2014-12-04 17:15:32]

https://codereview.chromium.org/756713003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
(right):

https://codereview.chromium.org/756713003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:267:
"about:blank about:blank*Toolbar toolbar Reload Button"));
On 2014/11/29 08:03:59, dmazzoni wrote:
> Why is about:blank there twice? How about the shortest possible string that
> applies to this specific test, maybe:
> 
> "*Toolbar toolbar Reload Button".
> 

about:blank is there twice because the ancestry 'enter' rule sees two window
with that $name; we should clean up the window names in the desktop tree a bit.

I like having the names there so we can see the exact output. It feels brittle
to me probably because this was a big change which we hopefully won't do much of
moving forward.

https://codereview.chromium.org/756713003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:341: if
(MatchPattern(utterance, "*Bluetooth* Button"))
On 2014/11/29 08:03:59, dmazzoni wrote:
> BTW, are you sure you want to remove this comma between the name and the role?
> Maybe it'd be better to leave the comma there.

It depends. Commas between name role and state seems ok but does introduce
pauses where we may not need them. Maybe a good question for UX studies?

https://codereview.chromium.org/756713003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:540:
"about:blank about:blank*Toolbar toolbar Reload Button"));
On 2014/11/29 08:03:59, dmazzoni wrote:
> same as above

Ditto.

[David Tseng, 2014-12-04 22:35:39]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2014-12-04 22:36:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/756713003/60001

[commit-bot: I haz the power, 2014-12-05 00:00:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 00:00:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2014-12-05 00:10:27]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2014-12-05 00:10:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/756713003/60001

[commit-bot: I haz the power, 2014-12-05 01:04:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 01:04:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2014-12-05 17:21:25]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2014-12-05 17:22:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/756713003/60001

[David Tseng, 2014-12-05 18:03:44]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2014-12-05 18:03:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/756713003/80001

[commit-bot: I haz the power, 2014-12-05 18:57:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 18:57:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2014-12-05 22:31:29]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2014-12-05 22:32:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/756713003/120001

[commit-bot: I haz the power, 2014-12-05 23:32:33]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2014-12-05 23:33:36]

Patchset 7 (id:??) landed as
https://crrev.com/bae9fa8fefa8b21115d049ce6562480b0f892969
Cr-Commit-Position: refs/heads/master@{#307110}