Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 756673004: Surfaces should acknowledge frame submissions (Closed)

Created:
6 years ago by abarth-chromium
Modified:
6 years ago
Reviewers:
jamesr
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, rafaelw, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Surfaces should acknowledge frame submissions Previously, there was no way for clients of the surfaces service to appropriately rate-limit their frame submissions. We tried using the "return resources" signal to rate-limit, but that's really a measure of how quickly you're submitting new resources rather than how quickly the system is putting up frames. Currently, only the Sky compositor listens to this signal. Using this signal, we're able to run sky/examples/spinning-square.sky in sync with the surfaces service (that is, submitting exactly one frames every 17ms). R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3374c8e724eb43c7ec1813999144dcc5f435c219

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -68 lines) Patch
M examples/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ganesh_app/texture_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/child_gl_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M examples/surfaces_app/child_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/embedder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/aura/surface_binding.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/cc/output_surface_mojo.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/native_viewport/viewport_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/surfaces/surfaces.mojom View 1 chunk +1 line, -1 line 1 comment Download
M mojo/services/surfaces/surfaces_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/surfaces/surfaces_impl.cc View 4 chunks +12 lines, -3 lines 0 comments Download
M mojo/services/surfaces/surfaces_service_application.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/view_manager/display_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sky/compositor/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/compositor/layer_host.h View 2 chunks +12 lines, -11 lines 0 comments Download
M sky/compositor/layer_host.cc View 5 chunks +38 lines, -36 lines 0 comments Download
M sky/compositor/surface_holder.h View 3 chunks +3 lines, -1 line 0 comments Download
M sky/compositor/surface_holder.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years ago (2014-11-24 20:24:55 UTC) #1
jamesr
Now that you have a state machine you probably want to add a unit test ...
6 years ago (2014-11-24 20:42:02 UTC) #2
abarth-chromium
6 years ago (2014-11-25 00:21:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3374c8e724eb43c7ec1813999144dcc5f435c219 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698