Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/common/chrome_switches.cc

Issue 756653005: Change the flag which enables OOP PDF to an enable/disable flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/chrome_switches.h ('k') | chrome/renderer/printing/print_web_view_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_switches.h" 5 #include "chrome/common/chrome_switches.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 9
10 namespace switches { 10 namespace switches {
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 // Disable auto-reload of error pages if offline. 292 // Disable auto-reload of error pages if offline.
293 const char kDisableOfflineAutoReload[] = "disable-offline-auto-reload"; 293 const char kDisableOfflineAutoReload[] = "disable-offline-auto-reload";
294 294
295 // Disable only auto-reloading error pages when the tab is visible. 295 // Disable only auto-reloading error pages when the tab is visible.
296 const char kDisableOfflineAutoReloadVisibleOnly[] = 296 const char kDisableOfflineAutoReloadVisibleOnly[] =
297 "disable-offline-auto-reload-visible-only"; 297 "disable-offline-auto-reload-visible-only";
298 298
299 // Disable the origin chip. 299 // Disable the origin chip.
300 const char kDisableOriginChip[] = "disable-origin-chip"; 300 const char kDisableOriginChip[] = "disable-origin-chip";
301 301
302 // Disable the out of process PDF plugin.
303 const char kDisableOutOfProcessPdf[] = "disable-out-of-process-pdf";
304
302 // Disable the setting to prompt the user for their OS account password before 305 // Disable the setting to prompt the user for their OS account password before
303 // revealing plaintext passwords in the password manager. 306 // revealing plaintext passwords in the password manager.
304 const char kDisablePasswordManagerReauthentication[] = 307 const char kDisablePasswordManagerReauthentication[] =
305 "disable-password-manager-reauthentication"; 308 "disable-password-manager-reauthentication";
306 309
307 // Enables searching for people from the apps list search box. 310 // Enables searching for people from the apps list search box.
308 const char kDisablePeopleSearch[] = "disable-people-search"; 311 const char kDisablePeopleSearch[] = "disable-people-search";
309 312
310 // Don't use bubbles for content permissions requests instead of infobars. 313 // Don't use bubbles for content permissions requests instead of infobars.
311 const char kDisablePermissionsBubbles[] = "disable-permissions-bubbles"; 314 const char kDisablePermissionsBubbles[] = "disable-permissions-bubbles";
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 // enabled. 513 // enabled.
511 // 514 //
512 // We're using independent flags here (as opposed to a common flag with 515 // We're using independent flags here (as opposed to a common flag with
513 // different values) to be able to enable/disable the entire experience 516 // different values) to be able to enable/disable the entire experience
514 // associated with this feature server-side from the FieldTrial (the complete 517 // associated with this feature server-side from the FieldTrial (the complete
515 // experience includes other flag changes as well). It is not currently possible 518 // experience includes other flag changes as well). It is not currently possible
516 // to do that with "flag=value" flags. 519 // to do that with "flag=value" flags.
517 const char kEnableOriginChipAlways[] = "enable-origin-chip-always"; 520 const char kEnableOriginChipAlways[] = "enable-origin-chip-always";
518 const char kEnableOriginChipOnSrp[] = "enable-origin-chip-on-srp"; 521 const char kEnableOriginChipOnSrp[] = "enable-origin-chip-on-srp";
519 522
523 // Enable the out of process PDF plugin.
524 const char kEnableOutOfProcessPdf[] = "enable-out-of-process-pdf";
525
520 // Enables panels (always on-top docked pop-up windows). 526 // Enables panels (always on-top docked pop-up windows).
521 const char kEnablePanels[] = "enable-panels"; 527 const char kEnablePanels[] = "enable-panels";
522 528
523 // Enables presenting plugin placeholder content as shadow DOM. 529 // Enables presenting plugin placeholder content as shadow DOM.
524 const char kEnablePluginPlaceholderShadowDom[] = 530 const char kEnablePluginPlaceholderShadowDom[] =
525 "enable-plugin-placeholder-shadow-dom"; 531 "enable-plugin-placeholder-shadow-dom";
526 532
527 // Enables the Power overlay in Settings. 533 // Enables the Power overlay in Settings.
528 const char kEnablePowerOverlay[] = "enable-power-overlay"; 534 const char kEnablePowerOverlay[] = "enable-power-overlay";
529 535
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
877 // Launches URL in new browser window. 883 // Launches URL in new browser window.
878 const char kOpenInNewWindow[] = "new-window"; 884 const char kOpenInNewWindow[] = "new-window";
879 885
880 // Force use of QUIC for requests to the specified origin. 886 // Force use of QUIC for requests to the specified origin.
881 const char kOriginToForceQuicOn[] = "origin-to-force-quic-on"; 887 const char kOriginToForceQuicOn[] = "origin-to-force-quic-on";
882 888
883 // The time that a new chrome process which is delegating to an already running 889 // The time that a new chrome process which is delegating to an already running
884 // chrome process started. (See ProcessSingleton for more details.) 890 // chrome process started. (See ProcessSingleton for more details.)
885 const char kOriginalProcessStartTime[] = "original-process-start-time"; 891 const char kOriginalProcessStartTime[] = "original-process-start-time";
886 892
887 // Enable the out of process PDF plugin.
888 const char kOutOfProcessPdf[] = "out-of-process-pdf";
889
890 // Packages an extension to a .crx installable file from a given directory. 893 // Packages an extension to a .crx installable file from a given directory.
891 const char kPackExtension[] = "pack-extension"; 894 const char kPackExtension[] = "pack-extension";
892 895
893 // Optional PEM private key to use in signing packaged .crx. 896 // Optional PEM private key to use in signing packaged .crx.
894 const char kPackExtensionKey[] = "pack-extension-key"; 897 const char kPackExtensionKey[] = "pack-extension-key";
895 898
896 // Specifies the path to the user data folder for the parent profile. 899 // Specifies the path to the user data folder for the parent profile.
897 const char kParentProfile[] = "parent-profile"; 900 const char kParentProfile[] = "parent-profile";
898 901
899 // Development flag for permission request API. This flag is needed until 902 // Development flag for permission request API. This flag is needed until
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
1359 // Enables overriding the path of file manager extension. 1362 // Enables overriding the path of file manager extension.
1360 const char kFileManagerExtensionPath[] = "filemgr-ext-path"; 1363 const char kFileManagerExtensionPath[] = "filemgr-ext-path";
1361 #endif 1364 #endif
1362 1365
1363 bool AboutInSettingsEnabled() { 1366 bool AboutInSettingsEnabled() {
1364 return SettingsWindowEnabled() && 1367 return SettingsWindowEnabled() &&
1365 !CommandLine::ForCurrentProcess()->HasSwitch( 1368 !CommandLine::ForCurrentProcess()->HasSwitch(
1366 ::switches::kDisableAboutInSettings); 1369 ::switches::kDisableAboutInSettings);
1367 } 1370 }
1368 1371
1372 bool OutOfProcessPdfEnabled() {
1373 if (CommandLine::ForCurrentProcess()->HasSwitch(kEnableOutOfProcessPdf))
1374 return true;
1375
1376 if (CommandLine::ForCurrentProcess()->HasSwitch(kDisableOutOfProcessPdf))
1377 return false;
1378
1379 // Default.
1380 return false;
1381 }
1382
1369 bool SettingsWindowEnabled() { 1383 bool SettingsWindowEnabled() {
1370 #if defined(OS_CHROMEOS) 1384 #if defined(OS_CHROMEOS)
1371 return !CommandLine::ForCurrentProcess()->HasSwitch( 1385 return !CommandLine::ForCurrentProcess()->HasSwitch(
1372 ::switches::kDisableSettingsWindow); 1386 ::switches::kDisableSettingsWindow);
1373 #else 1387 #else
1374 return CommandLine::ForCurrentProcess()->HasSwitch( 1388 return CommandLine::ForCurrentProcess()->HasSwitch(
1375 ::switches::kEnableSettingsWindow); 1389 ::switches::kEnableSettingsWindow);
1376 #endif 1390 #endif
1377 } 1391 }
1378 1392
1379 #if defined(OS_CHROMEOS) 1393 #if defined(OS_CHROMEOS)
1380 bool PowerOverlayEnabled() { 1394 bool PowerOverlayEnabled() {
1381 return CommandLine::ForCurrentProcess()->HasSwitch( 1395 return CommandLine::ForCurrentProcess()->HasSwitch(
1382 ::switches::kEnablePowerOverlay); 1396 ::switches::kEnablePowerOverlay);
1383 } 1397 }
1384 #endif 1398 #endif
1385 1399
1386 // ----------------------------------------------------------------------------- 1400 // -----------------------------------------------------------------------------
1387 // DO NOT ADD YOUR CRAP TO THE BOTTOM OF THIS FILE. 1401 // DO NOT ADD YOUR CRAP TO THE BOTTOM OF THIS FILE.
1388 // 1402 //
1389 // You were going to just dump your switches here, weren't you? Instead, please 1403 // You were going to just dump your switches here, weren't you? Instead, please
1390 // put them in alphabetical order above, or in order inside the appropriate 1404 // put them in alphabetical order above, or in order inside the appropriate
1391 // ifdef at the bottom. The order should match the header. 1405 // ifdef at the bottom. The order should match the header.
1392 // ----------------------------------------------------------------------------- 1406 // -----------------------------------------------------------------------------
1393 1407
1394 } // namespace switches 1408 } // namespace switches
OLDNEW
« no previous file with comments | « chrome/common/chrome_switches.h ('k') | chrome/renderer/printing/print_web_view_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698