Remote assistance on Chrome OS Part IX - Input injection on Ozone

remoting/host/client_session.cc

Index: remoting/host/client_session.cc
diff --git a/remoting/host/client_session.cc b/remoting/host/client_session.cc
index 5b7daba3a74cd22e249ec1f4cab82fa705e12176..5fc430ae2957e5724bdae34fa6f6fb02050093d8 100644
--- a/remoting/host/client_session.cc
+++ b/remoting/host/client_session.cc
@@ -18,6 +18,7 @@
 #include "remoting/host/audio_capturer.h"
 #include "remoting/host/audio_scheduler.h"
 #include "remoting/host/desktop_environment.h"
+#include "remoting/host/display_rotation_filter.h"
 #include "remoting/host/host_extension_session.h"
 #include "remoting/host/input_injector.h"
 #include "remoting/host/screen_controls.h"
@@ -54,7 +55,9 @@ ClientSession::ClientSession(
       desktop_environment_factory_(desktop_environment_factory),
       input_tracker_(&host_input_filter_),
       remote_input_filter_(&input_tracker_),
-      mouse_clamping_filter_(&remote_input_filter_),
+      display_rotation_filter_(
+          CreateDisplayRotationFilter(&remote_input_filter_)),

[Wez, 2014/11/26 02:28:34]

This feels like a property of the DesktopEnvironment, not a process-global
property - it may even be better to push creation of this filter into the
DesktopEnvironment for CrOS.

[kelvinp, 2014/12/02 00:12:26]

Done.

[kelvinp, 2014/12/02 00:12:26]

Done.

+      mouse_clamping_filter_(display_rotation_filter_.get()),

[Wez, 2014/11/26 02:28:34]

Use *display_rotation_filter_ here. In general, avoid using scoped_ptr<>::get()
unless you really really need to; operator* and operator-> will both DCHECK if
the scoped_ptr<> is NULL, to give clean failures.

[kelvinp, 2014/12/02 00:12:26]

*display_rotation_filter_  returns an InputStub&, but the constructor of of
MouseClampingFilter expects a InputStub*

       disable_input_filter_(mouse_clamping_filter_.input_filter()),
       disable_clipboard_filter_(clipboard_echo_filter_.host_filter()),
       auth_input_filter_(&disable_input_filter_),