Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 756643002: [turbofan] Fix lea matching. (Closed)

Created:
6 years ago by Jarin
Modified:
6 years ago
Reviewers:
danno
CC:
v8-dev, Sven Panne
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix matching of the lea instruction. Resets the scaled exponent to 0 when the scaling match fails. BUG=

Patch Set 1 #

Patch Set 2 : Unit test & fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M src/compiler/node-matchers.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-lea-matching.js View 1 chunk +8 lines, -8 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jarin
Could you take a look, please?
6 years ago (2014-11-24 15:54:32 UTC) #2
danno
lgtm
6 years ago (2014-11-24 16:34:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756643002/20001
6 years ago (2014-11-24 16:35:03 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-24 17:45:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698