Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 756603003: Add ChildPortHandshake and its test (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@child_port_server
Project:
crashpad
Visibility:
Public.

Description

Add ChildPortHandshake and its test. ChildPortHandshake is the most generic system yet to allow child processes to provide their parents with Mach rights. These are ordinarily expected to be send rights to the children’s own task ports, or send rights to servers that the children hold receive rights to. This updates DEPS to pull mini_chromium 1d3523dbda93, which includes base::mac::ScopedMachPortSet. TEST=util_test ChildPortHandshake.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/85c9318597d74c6d33afa88679e88e5d3394526c

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address review feedback #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+753 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A util/mach/child_port_handshake.h View 1 1 chunk +226 lines, -0 lines 0 comments Download
A util/mach/child_port_handshake.cc View 1 2 1 chunk +335 lines, -0 lines 0 comments Download
A util/mach/child_port_handshake_test.cc View 1 chunk +188 lines, -0 lines 0 comments Download
M util/util.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
This depends on: https://codereview.chromium.org/752243002/ (child_port Mach subsystem) https://codereview.chromium.org/754123002/ (ChildPortServer) https://codereview.chromium.org/756653004/ (LoggingWriteFD())
6 years ago (2014-11-24 20:37:48 UTC) #2
Robert Sesek
https://codereview.chromium.org/756603003/diff/1/util/mach/child_port_handshake.h File util/mach/child_port_handshake.h (right): https://codereview.chromium.org/756603003/diff/1/util/mach/child_port_handshake.h#newcode61 util/mach/child_port_handshake.h:61: //! child disassociates from the parent with a double ...
6 years ago (2014-11-25 18:29:27 UTC) #3
Mark Mentovai
Updated. https://codereview.chromium.org/756603003/diff/1/util/mach/child_port_handshake.h File util/mach/child_port_handshake.h (right): https://codereview.chromium.org/756603003/diff/1/util/mach/child_port_handshake.h#newcode84 util/mach/child_port_handshake.h:84: ~ChildPortHandshake(); Robert Sesek wrote: > override ? It’s ...
6 years ago (2014-11-25 19:20:30 UTC) #4
Robert Sesek
LGTM
6 years ago (2014-11-25 19:31:45 UTC) #5
Mark Mentovai
6 years ago (2014-11-25 19:56:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
85c9318597d74c6d33afa88679e88e5d3394526c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698