Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 756593002: Revert of Revert of Supervised user SafeSites: Expose & use API key from src-internal (Closed)

Created:
6 years ago by Marc Treib
Modified:
6 years ago
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Supervised user SafeSites: Expose & use API key from src-internal (patchset #1 id:1 of https://codereview.chromium.org/753683004/) Reason for revert: Relanding because the original reason for reverting looks like a flake rather than an issue with the CL. Original issue's description: > Revert of Supervised user SafeSites: Expose & use API key from src-internal (patchset #5 id:80001 of https://codereview.chromium.org/690423003/) > > Reason for revert: > Build breakage on Mac: > > https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/14318/steps/steps/logs/stdio > > Original issue's description: > > Supervised user SafeSites: Expose & use API key from src-internal > > > > Key was added to src-internal in https://chromereviews.googleplex.com/113767014/ > > > > BUG=417722 > > > > Committed: https://crrev.com/2ee5f146d57d07bbad3804715e06590b850711f9 > > Cr-Commit-Position: refs/heads/master@{#305412} > > TBR=rogerta@chromium.org,bauerb@chromium.org,treib@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=417722 > > Committed: https://crrev.com/13c88c66f60e6364478a411e8ccf0bfd689f0a96 > Cr-Commit-Position: refs/heads/master@{#305413} TBR=rogerta@chromium.org,bauerb@chromium.org,tnagel@chromium.org NOTRY=true BUG=417722 Committed: https://crrev.com/e81fd0f30e02e007ba86c63c9a1ce5299150fc54 Cr-Commit-Position: refs/heads/master@{#305416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -34 lines) Patch
M chrome/browser/supervised_user/experimental/supervised_user_async_url_checker.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/supervised_user/experimental/supervised_user_async_url_checker.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M google_apis/google_api_keys.h View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/google_api_keys.cc View 5 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Marc Treib
Created Revert of Revert of Supervised user SafeSites: Expose & use API key from src-internal
6 years ago (2014-11-24 12:33:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756593002/1
6 years ago (2014-11-24 12:35:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-24 12:35:55 UTC) #4
commit-bot: I haz the power
6 years ago (2014-11-24 12:36:39 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e81fd0f30e02e007ba86c63c9a1ce5299150fc54
Cr-Commit-Position: refs/heads/master@{#305416}

Powered by Google App Engine
This is Rietveld 408576698