Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: src/heap/mark-compact.h

Issue 756553002: Don't verify evacuation when it is not completed. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.h
diff --git a/src/heap/mark-compact.h b/src/heap/mark-compact.h
index cd2c9b68c834be428cc7475823995e7ec420e7ba..1b399f3c5eef19661ec5ff3275f109c8f563e49b 100644
--- a/src/heap/mark-compact.h
+++ b/src/heap/mark-compact.h
@@ -643,11 +643,9 @@ class MarkCompactCollector {
// Checks if sweeping is in progress right now on any space.
bool sweeping_in_progress() { return sweeping_in_progress_; }
- void set_sequential_sweeping(bool sequential_sweeping) {
- sequential_sweeping_ = sequential_sweeping;
- }
+ void set_evacuation(bool evacuation) { evacuation_ = evacuation; }
- bool sequential_sweeping() const { return sequential_sweeping_; }
+ bool evacuation() const { return evacuation_; }
// Mark the global table which maps weak objects to dependent code without
// marking its contents.
@@ -704,7 +702,7 @@ class MarkCompactCollector {
base::Semaphore pending_sweeper_jobs_semaphore_;
- bool sequential_sweeping_;
+ bool evacuation_;
SlotsBufferAllocator slots_buffer_allocator_;
@@ -934,14 +932,14 @@ class MarkBitCellIterator BASE_EMBEDDED {
};
-class SequentialSweepingScope BASE_EMBEDDED {
+class EvacuationScope BASE_EMBEDDED {
public:
- explicit SequentialSweepingScope(MarkCompactCollector* collector)
+ explicit EvacuationScope(MarkCompactCollector* collector)
: collector_(collector) {
- collector_->set_sequential_sweeping(true);
+ collector_->set_evacuation(true);
}
- ~SequentialSweepingScope() { collector_->set_sequential_sweeping(false); }
+ ~EvacuationScope() { collector_->set_evacuation(false); }
private:
MarkCompactCollector* collector_;
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698