Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: tests_lit/llvm2ice_tests/unreachable.ll

Issue 756543002: Subzero: Fix new issues after the LLVM 3.5 merge. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Also use `llvm-config --system-libs` Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests_lit/llvm2ice_tests/undef.ll ('k') | tests_lit/llvm2ice_tests/vector-arg.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests_lit/llvm2ice_tests/unreachable.ll
diff --git a/tests_lit/llvm2ice_tests/unreachable.ll b/tests_lit/llvm2ice_tests/unreachable.ll
index 5fda09cddf1164ae3c102fb969d9b5a379a6d458..7938e178a568a80e5c79db487b4dc89c8758a7b2 100644
--- a/tests_lit/llvm2ice_tests/unreachable.ll
+++ b/tests_lit/llvm2ice_tests/unreachable.ll
@@ -1,11 +1,5 @@
; This tests the basic structure of the Unreachable instruction.
-; TODO(jvoung): fix extra "CALLTARGETS" run. The llvm-objdump symbolizer
-; doesn't know how to symbolize non-section-local functions.
-; The newer LLVM 3.6 one does work, but watch out for other bugs.
-
-; RUN: %p2i -i %s -a -O2 --verbose none \
-; RUN: | FileCheck --check-prefix=CALLTARGETS %s
; RUN: %p2i -i %s -a -O2 --verbose none \
; RUN: | llvm-mc -triple=i686-none-nacl -filetype=obj \
; RUN: | llvm-objdump -d --symbolize -x86-asm-syntax=intel - | FileCheck %s
@@ -27,10 +21,8 @@ return: ; preds = %entry
}
; CHECK-LABEL: divide
-; CALLTARGETS-LABEL: divide
; CHECK: cmp
-; CHECK: call -4
-; CALLTARGETS: .long ice_unreachable
+; CHECK: call ice_unreachable
; CHECK: cdq
; CHECK: idiv
; CHECK: ret
« no previous file with comments | « tests_lit/llvm2ice_tests/undef.ll ('k') | tests_lit/llvm2ice_tests/vector-arg.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698