Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: Source/WebCore/inspector/InspectorPageAgent.cpp

Issue 7565004: Merge 91901 - Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/inspector/InspectorPageAgent.cpp
===================================================================
--- Source/WebCore/inspector/InspectorPageAgent.cpp (revision 92265)
+++ Source/WebCore/inspector/InspectorPageAgent.cpp (working copy)
@@ -299,6 +299,8 @@
void InspectorPageAgent::open(ErrorString*, const String& url, const bool* const inNewWindow)
{
+ UserGestureIndicator indicator(DefinitelyProcessingUserGesture);
+
Frame* mainFrame = m_page->mainFrame();
Frame* frame;
if (inNewWindow && *inNewWindow) {
@@ -315,7 +317,6 @@
} else
frame = mainFrame;
- UserGestureIndicator indicator(DefinitelyProcessingUserGesture);
// FIXME: Why does one use mainFrame and the other frame?
frame->loader()->changeLocation(mainFrame->document()->securityOrigin(), frame->document()->completeURL(url), "", false, false);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698