Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 756423006: Optimize GetPrototype (Closed)

Created:
6 years ago by arv (Not doing code reviews)
Modified:
6 years ago
CC:
adamk, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Optimize GetPrototype This introduces Hydrogen for %_GetPrototype. The code falls back on runtime if the object needs access checks or if its prototype is a hidden prototype. BUG=None LOG=Y R=dslomov@chromium.org

Patch Set 1 #

Patch Set 2 : Skip push/pop #

Total comments: 2

Patch Set 3 : Add test and add back Push/Pop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -9 lines) Patch
M src/array.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/messages.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8natives.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
arv (Not doing code reviews)
Motivation: I want to use GetPrototype in the default constructor for classes.
6 years ago (2014-12-05 15:15:04 UTC) #2
arv (Not doing code reviews)
Skip push/pop
6 years ago (2014-12-05 15:29:13 UTC) #3
arv (Not doing code reviews)
PTAL https://codereview.chromium.org/756423006/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/756423006/diff/20001/src/hydrogen.cc#newcode12432 src/hydrogen.cc:12432: ast_context()->ReturnValue(result); Other places usually do a push/pop in ...
6 years ago (2014-12-05 15:30:05 UTC) #4
Dmitry Lomov (no reviews)
excellent, looks good, will also come handy for enabling hydrogen for 'super(...)' calls. This need ...
6 years ago (2014-12-05 15:30:28 UTC) #5
Dmitry Lomov (no reviews)
Nit https://codereview.chromium.org/756423006/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/756423006/diff/20001/src/hydrogen.cc#newcode12432 src/hydrogen.cc:12432: ast_context()->ReturnValue(result); On 2014/12/05 15:30:05, arv wrote: > Other ...
6 years ago (2014-12-05 15:39:20 UTC) #6
arv (Not doing code reviews)
Add test and add back Push/Pop
6 years ago (2014-12-05 16:45:24 UTC) #7
arv (Not doing code reviews)
PTAL
6 years ago (2014-12-05 16:46:09 UTC) #8
Dmitry Lomov (no reviews)
lgtm, thanks!
6 years ago (2014-12-05 20:04:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756423006/40001
6 years ago (2014-12-05 20:10:14 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-05 20:36:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698