Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 756403003: Adding SpinButtonRole in isClickable() (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adding SpinButtonRole in isClickable() Layout test case accessibility/clickable.html was failing. And accessibility/nochildren-elements.html this Layout test is passing which was depending on https://codereview.chromium.org/753663003/ is now merged. BUG=385014 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
shreeramk
Please review. Thanks!!!
6 years ago (2014-11-26 07:45:19 UTC) #2
dmazzoni
lgtm
6 years ago (2014-11-26 18:04:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756403003/1
6 years ago (2014-11-26 18:05:26 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-26 19:15:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186047

Powered by Google App Engine
This is Rietveld 408576698