Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: pkg/compiler/lib/src/cps_ir/constant_propagation.dart

Issue 756383004: Refactored treatment of closure variables in dart2js CPS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer2dart/test/sexpr_test.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/constant_propagation.dart
diff --git a/pkg/compiler/lib/src/cps_ir/constant_propagation.dart b/pkg/compiler/lib/src/cps_ir/constant_propagation.dart
index 975a53180db7b95d9d15cc200b2b5e7cb0901305..c9adf089d055cb93124b59faaef4fa3db00dd64e 100644
--- a/pkg/compiler/lib/src/cps_ir/constant_propagation.dart
+++ b/pkg/compiler/lib/src/cps_ir/constant_propagation.dart
@@ -308,7 +308,7 @@ class _ConstPropagationVisitor extends Visitor {
}
void visitFunctionDefinition(FunctionDefinition node) {
- node.parameters.forEach(visitParameter);
+ node.parameters.forEach(visit);
setReachable(node.body);
}
@@ -586,6 +586,9 @@ class _ConstPropagationVisitor extends Visitor {
setValue(node, _ConstnessLattice.NonConst);
}
+ void visitClosureVariable(ClosureVariable node) {
+ }
+
void visitParameter(Parameter node) {
if (node.parent is FunctionDefinition) {
// Functions may escape and thus their parameters must be initialized to
« no previous file with comments | « pkg/analyzer2dart/test/sexpr_test.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698