Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: pkg/analyzer2dart/lib/src/cps_generator.dart

Issue 756383004: Refactored treatment of closure variables in dart2js CPS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer2dart/test/sexpr_data.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer2dart/lib/src/cps_generator.dart
diff --git a/pkg/analyzer2dart/lib/src/cps_generator.dart b/pkg/analyzer2dart/lib/src/cps_generator.dart
index b8ca03926356dc802591007acea44cf0bd8e4482..7efa4230461449f143e5dbec2adc3d6d24876d7f 100644
--- a/pkg/analyzer2dart/lib/src/cps_generator.dart
+++ b/pkg/analyzer2dart/lib/src/cps_generator.dart
@@ -87,7 +87,7 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
function.parameters.forEach((analyzer.ParameterElement parameter) {
// TODO(johnniwinther): Support "closure variables", that is variables
// accessed from an inner function.
- irBuilder.createParameter(converter.convertElement(parameter));
+ irBuilder.createFunctionParameter(converter.convertElement(parameter));
});
// Visit the body directly to avoid processing the signature as
// expressions.
« no previous file with comments | « no previous file | pkg/analyzer2dart/test/sexpr_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698