pkg/analyzer2dart/lib/src/cps_generator.dart - Issue 756383004: Refactored treatment of closure variables in dart2js CPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer2dart/lib/src/cps_generator.dart

Issue 756383004: Refactored treatment of closure variables in dart2js CPS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer2dart/lib/src/cps_generator.dart

diff --git a/pkg/analyzer2dart/lib/src/cps_generator.dart b/pkg/analyzer2dart/lib/src/cps_generator.dart

index b8ca03926356dc802591007acea44cf0bd8e4482..7efa4230461449f143e5dbec2adc3d6d24876d7f 100644

--- a/pkg/analyzer2dart/lib/src/cps_generator.dart

+++ b/pkg/analyzer2dart/lib/src/cps_generator.dart

@@ -87,7 +87,7 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>

function.parameters.forEach((analyzer.ParameterElement parameter) {

// TODO(johnniwinther): Support "closure variables", that is variables

// accessed from an inner function.

- irBuilder.createParameter(converter.convertElement(parameter));

+ irBuilder.createFunctionParameter(converter.convertElement(parameter));

});

// Visit the body directly to avoid processing the signature as

// expressions.

« no previous file with comments | « no previous file | pkg/analyzer2dart/test/sexpr_data.dart » ('j') | pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart » ('J')