Prompt for unmasking Wallet credit card on Android

Prompt for unmasking Wallet credit card on Android

Bare-bones implementation. enable with new flag --enable-wallet-card-import.

BUG=437116
Committed: https://crrev.com/ecb659dff3cdc827b6228a61d05d0e3bb66cf969
Cr-Commit-Position: refs/heads/master@{#307854}

[Evan Stade, 2014-11-27 01:42:02]

This could probably be reviewed and committed after a little more cleanup. It's
rough, but it's a starting point.

[please use gerrit instead, 2014-11-28 20:55:55]

rouslan@chromium.org changed reviewers:
+ rouslan@chromium.org

[please use gerrit instead, 2014-11-28 20:55:56]

https://codereview.chromium.org/756333003/diff/40001/ui/android/java/strings/...
File ui/android/java/strings/android_ui_strings.grd (right):

https://codereview.chromium.org/756333003/diff/40001/ui/android/java/strings/...
ui/android/java/strings/android_ui_strings.grd:225: </message>
If you want to use he same strings on all platforms, you should put them into
generated_resources.grd and pass them from C++ to Java.

[please use gerrit instead, 2014-11-28 20:56:25]

rouslan@chromium.org changed reviewers:
- rouslan@chromium.org

[please use gerrit instead, 2014-11-28 21:02:09]

InstrumentInmassPrompt.java should probably be in:

  chrome/android/java/src/org/chromium/chrome/browser/autofill/

(instrument_unmask_prompt.xml should be in chrome/android/java/res/layout)

[please use gerrit instead, 2014-11-28 21:07:45]

rouslan@chromium.org changed reviewers:
+ rouslan@chromium.org

[please use gerrit instead, 2014-11-28 21:07:46]

https://codereview.chromium.org/756333003/diff/40001/components/autofill/core...
File components/autofill/core/browser/popup_item_ids.h (right):

https://codereview.chromium.org/756333003/diff/40001/components/autofill/core...
components/autofill/core/browser/popup_item_ids.h:22:
POPUP_ITEM_ID_FAKE_MASKED_INSTRUMENT = -9,
If there're multiple fake masked instruments, each one needs a unique ID. That
way we can distinguish which instrument the user clicked.

[please use gerrit instead, 2014-11-28 21:07:55]

rouslan@chromium.org changed reviewers:
- rouslan@chromium.org

[Evan Stade, 2014-12-01 21:36:24]

On 2014/11/28 21:02:09, Rouslan Solomakhin wrote:
> InstrumentInmassPrompt.java should probably be in:
> 
>   chrome/android/java/src/org/chromium/chrome/browser/autofill/
> 
> (instrument_unmask_prompt.xml should be in chrome/android/java/res/layout)

why? It's UI. I put it next to AutofillPopup.java. The stuff in that folder
appears to be controller stuff (and there's no ui/ in the path).

https://codereview.chromium.org/756333003/diff/40001/components/autofill/core...
File components/autofill/core/browser/popup_item_ids.h (right):

https://codereview.chromium.org/756333003/diff/40001/components/autofill/core...
components/autofill/core/browser/popup_item_ids.h:22:
POPUP_ITEM_ID_FAKE_MASKED_INSTRUMENT = -9,
On 2014/11/28 21:07:46, Rouslan Solomakhin wrote:
> If there're multiple fake masked instruments, each one needs a unique ID. That
> way we can distinguish which instrument the user clicked.

This "fake" masked instrument is here for testing purposes. This won't exist
once we have real masked instruments available.

https://codereview.chromium.org/756333003/diff/40001/ui/android/java/strings/...
File ui/android/java/strings/android_ui_strings.grd (right):

https://codereview.chromium.org/756333003/diff/40001/ui/android/java/strings/...
ui/android/java/strings/android_ui_strings.grd:225: </message>
On 2014/11/28 20:55:56, Rouslan Solomakhin wrote:
> If you want to use he same strings on all platforms, you should put them into
> generated_resources.grd and pass them from C++ to Java.

strings aren't finalized but I suspect they may be different due to space
constraints

[Evan Stade, 2014-12-01 21:50:03]

estade@chromium.org changed reviewers:
+ aruslan@chromium.org, tedchoc@chromium.org

[Evan Stade, 2014-12-01 21:50:04]

Ted, Ruslan, please review.

Background: the UI for this feature is not finalized, and the backend is not
implemented. So this is a first step in the right general direction from which
we can iterate, and it will give us something to hook the backend into when it
becomes available. I didn't attempt to make it super pretty. Everything in this
CL is hidden behind a flag, so things like untranslated strings won't be visible
to users.

tedchoc:
  chrome/browser/android/chrome_jni_registrar.cc
  ui/android/java/res/layout/instrument_unmask_prompt.xml
  ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java
  ui/android/java/strings/android_ui_strings.grd
aruslan:
 
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java
  chrome/browser/ui/android/autofill/instrument_unmask_prompt_view_android.cc
  chrome/browser/ui/android/autofill/instrument_unmask_prompt_view_android.h

[Evan Stade, 2014-12-03 17:08:23]

ping tedchoc and aruslan

[aruslan, 2014-12-03 23:37:11]

On 2014/12/03 17:08:23, Evan Stade wrote:
> ping tedchoc and aruslan

Hi Evan -- I'm not sure what I'm looking at; it doesn't look like a production
code -- do you plan to submit it in its current form?
If so, please let us know and please fix
android_webview/native/aw_autofill_client.h compilation issues.

[aruslan, 2014-12-04 00:15:46]

aruslan@chromium.org changed reviewers:
+ aurimas@chromium.org

[aruslan, 2014-12-04 00:15:48]

Replacing myself with aurimas@ as a AutofillPopupBridge owner.

https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java
(right):

https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:35:
dismissed(new String());
Should we separate "dismissed with a response" and "cancelled/dismissed without
a response"?

https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:55:
* Hides the Autofill Popup and removes its anchor from the ContainerView.
There is no anchor I guess.

https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:72:
String response);
indent +8 starting from the start of the "private".

https://codereview.chromium.org/756333003/diff/240001/ui/android/java/src/org...
File ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java
(right):

https://codereview.chromium.org/756333003/diff/240001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java:67:
mDelegate.dismissed("");
It's dismissed(new String()) in InstrumentUnmaskBridge.java.
Again, should it be "cancelled" or something?

[Ted C, 2014-12-04 00:53:30]

Per our offline discussion, I think Instrument is a horrendous name.

We discussed adding the word payment to make this clearer, but I think in all
cases, we could just replace instrument with payment and probably achieve the
same effect without lengthening it too much.

https://chromiumcodereview.appspot.com/756333003/diff/240001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java
(right):

https://chromiumcodereview.appspot.com/756333003/diff/240001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:20:
public class InstrumentUnmaskBridge implements InstrumentUnmaskPromptDelegate {
Did you forget to include InstrumentUnmaskPromptDelegate?

https://chromiumcodereview.appspot.com/756333003/diff/240001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:35:
dismissed(new String());
and in general, we'd do "" instead of new String()

https://chromiumcodereview.appspot.com/756333003/diff/240001/ui/android/java/...
File ui/android/java/res/layout/instrument_unmask_prompt.xml (right):

https://chromiumcodereview.appspot.com/756333003/diff/240001/ui/android/java/...
ui/android/java/res/layout/instrument_unmask_prompt.xml:35:
android:hint="@string/instrument_unmask_input_hint"
Add:
http://developer.android.com/reference/android/widget/TextView.html#attr_andr...

"number" should be what you want.  NumberPicker would be for picking 0-100 or
something like that, which isn't what you'd want.

https://chromiumcodereview.appspot.com/756333003/diff/240001/ui/android/java/...
File ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java
(right):

https://chromiumcodereview.appspot.com/756333003/diff/240001/ui/android/java/...
ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java:40:
.setTitle("Unlocking Visa - 1111")
these should be +4 indented

[Ted C, 2014-12-04 00:55:39]

https://chromiumcodereview.appspot.com/756333003/diff/240001/ui/android/java/...
File ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java
(right):

https://chromiumcodereview.appspot.com/756333003/diff/240001/ui/android/java/...
ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java:29:
public void dismissed(String response);
no need for public as all methods in interfaces are public.

Also please add javadoc as I have no idea what response is actually supposed to
be without looking at this class.  Maybe cvc is a better variable name.

[Ted C, 2014-12-04 00:57:17]

https://chromiumcodereview.appspot.com/756333003/diff/240001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java
(right):

https://chromiumcodereview.appspot.com/756333003/diff/240001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:20:
public class InstrumentUnmaskBridge implements InstrumentUnmaskPromptDelegate {
On 2014/12/04 00:53:29, Ted C wrote:
> Did you forget to include InstrumentUnmaskPromptDelegate?

Evan pointed it out that it's in the InstrumentUnmaskPrompt file.

[Evan Stade, 2014-12-05 03:46:22]

renamed Instrument to Card

https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java
(right):

https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:35:
dismissed(new String());
On 2014/12/04 00:15:47, aruslan wrote:
> Should we separate "dismissed with a response" and "cancelled/dismissed
without
> a response"?

Generally, this prompt is going to get more complicated. It will probably not
dismiss right away when you enter a value, but instead show a spinner as we get
the full instrument.

That said, for now, I don't see an advantage to having separate functions for
verify vs. cancel.

https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:35:
dismissed(new String());
On 2014/12/04 00:53:29, Ted C wrote:
> and in general, we'd do "" instead of new String()

Done.

https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:55:
* Hides the Autofill Popup and removes its anchor from the ContainerView.
On 2014/12/04 00:15:47, aruslan wrote:
> There is no anchor I guess.

thanks for pointing this out. The function actually isn't needed (at least not
yet). Removed.

https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:72:
String response);
On 2014/12/04 00:15:47, aruslan wrote:
> indent +8 starting from the start of the "private".

Done.

https://codereview.chromium.org/756333003/diff/240001/ui/android/java/src/org...
File ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java
(right):

https://codereview.chromium.org/756333003/diff/240001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java:29:
public void dismissed(String response);
On 2014/12/04 00:55:39, Ted C wrote:
> no need for public as all methods in interfaces are public.
> 
> Also please add javadoc as I have no idea what response is actually supposed
to
> be without looking at this class.  Maybe cvc is a better variable name.

removed public. Added docs. Changed variable name to to userResponse. Is that
clearer?

https://codereview.chromium.org/756333003/diff/240001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java:40:
.setTitle("Unlocking Visa - 1111")
On 2014/12/04 00:53:30, Ted C wrote:
> these should be +4 indented

Done.

https://codereview.chromium.org/756333003/diff/240001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java:67:
mDelegate.dismissed("");
On 2014/12/04 00:15:48, aruslan wrote:
> It's dismissed(new String()) in InstrumentUnmaskBridge.java.
> Again, should it be "cancelled" or something?

Addressed this there and changed that one to "".

[Evan Stade, 2014-12-08 18:44:07]

On 2014/12/05 03:46:22, Evan Stade wrote:
> renamed Instrument to Card
> 
>
https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java
> (right):
> 
>
https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:35:
> dismissed(new String());
> On 2014/12/04 00:15:47, aruslan wrote:
> > Should we separate "dismissed with a response" and "cancelled/dismissed
> without
> > a response"?
> 
> Generally, this prompt is going to get more complicated. It will probably not
> dismiss right away when you enter a value, but instead show a spinner as we
get
> the full instrument.
> 
> That said, for now, I don't see an advantage to having separate functions for
> verify vs. cancel.
> 
>
https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:35:
> dismissed(new String());
> On 2014/12/04 00:53:29, Ted C wrote:
> > and in general, we'd do "" instead of new String()
> 
> Done.
> 
>
https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:55:
> * Hides the Autofill Popup and removes its anchor from the ContainerView.
> On 2014/12/04 00:15:47, aruslan wrote:
> > There is no anchor I guess.
> 
> thanks for pointing this out. The function actually isn't needed (at least not
> yet). Removed.
> 
>
https://codereview.chromium.org/756333003/diff/240001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/autofill/InstrumentUnmaskBridge.java:72:
> String response);
> On 2014/12/04 00:15:47, aruslan wrote:
> > indent +8 starting from the start of the "private".
> 
> Done.
> 
>
https://codereview.chromium.org/756333003/diff/240001/ui/android/java/src/org...
> File ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java
> (right):
> 
>
https://codereview.chromium.org/756333003/diff/240001/ui/android/java/src/org...
> ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java:29:
> public void dismissed(String response);
> On 2014/12/04 00:55:39, Ted C wrote:
> > no need for public as all methods in interfaces are public.
> > 
> > Also please add javadoc as I have no idea what response is actually supposed
> to
> > be without looking at this class.  Maybe cvc is a better variable name.
> 
> removed public. Added docs. Changed variable name to to userResponse. Is that
> clearer?
> 
>
https://codereview.chromium.org/756333003/diff/240001/ui/android/java/src/org...
> ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java:40:
> .setTitle("Unlocking Visa - 1111")
> On 2014/12/04 00:53:30, Ted C wrote:
> > these should be +4 indented
> 
> Done.
> 
>
https://codereview.chromium.org/756333003/diff/240001/ui/android/java/src/org...
> ui/android/java/src/org/chromium/ui/autofill/InstrumentUnmaskPrompt.java:67:
> mDelegate.dismissed("");
> On 2014/12/04 00:15:48, aruslan wrote:
> > It's dismissed(new String()) in InstrumentUnmaskBridge.java.
> > Again, should it be "cancelled" or something?
> 
> Addressed this there and changed that one to "".

ping

[aruslan, 2014-12-09 23:57:38]

aruslan@chromium.org changed reviewers:
- aruslan@chromium.org

[aurimas (slooooooooow), 2014-12-10 00:49:24]

Java and JNI bits LGTM

https://codereview.chromium.org/756333003/diff/260001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java
(right):

https://codereview.chromium.org/756333003/diff/260001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java:50:
mCardUnmaskPrompt = null;
This line is causing a compile issue:
../chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java:50:
error: cannot assign a value to final variable mCardUnmaskPrompt
        mCardUnmaskPrompt = null;

[Evan Stade, 2014-12-10 01:25:57]

https://codereview.chromium.org/756333003/diff/260001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java
(right):

https://codereview.chromium.org/756333003/diff/260001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java:50:
mCardUnmaskPrompt = null;
On 2014/12/10 00:49:23, aurimas wrote:
> This line is causing a compile issue:
>
../chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java:50:
> error: cannot assign a value to final variable mCardUnmaskPrompt
>         mCardUnmaskPrompt = null;

hmm, not sure why I added this line..

[Evan Stade, 2014-12-10 01:46:06]

estade@chromium.org changed reviewers:
+ isherman@chromium.org, sgurun@chromium.org

[Evan Stade, 2014-12-10 01:46:07]

+sgurun for AW
+isherman for histograms.xml

[Ilya Sherman, 2014-12-10 02:09:39]

histograms.xml lgtm

[Ted C, 2014-12-10 22:05:00]

lgtm

https://codereview.chromium.org/756333003/diff/280001/chrome/browser/android/...
File chrome/browser/android/chrome_jni_registrar.cc (right):

https://codereview.chromium.org/756333003/diff/280001/chrome/browser/android/...
chrome/browser/android/chrome_jni_registrar.cc:164: {"CardUnmaskPrompt",
autofill::CardUnmaskPromptViewAndroid::Register},
reorder this one now

https://codereview.chromium.org/756333003/diff/280001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/chrome_autofill_client.h (right):

https://codereview.chromium.org/756333003/diff/280001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/chrome_autofill_client.h:30: class
InstrumentUnmaskPromptView;
delete?

https://codereview.chromium.org/756333003/diff/280001/ui/android/java/res/lay...
File ui/android/java/res/layout/autofill_card_unmask_prompt.xml (right):

https://codereview.chromium.org/756333003/diff/280001/ui/android/java/res/lay...
ui/android/java/res/layout/autofill_card_unmask_prompt.xml:25: <!--
TODO(estade): make this a NumberPicker? -->
I would remove this TODO as I don't think you'll ever want it to be.

[sgurun-gerrit only, 2014-12-10 22:09:04]

On 2014/12/10 22:05:00, Ted C wrote:
> lgtm
> 
>
https://codereview.chromium.org/756333003/diff/280001/chrome/browser/android/...
> File chrome/browser/android/chrome_jni_registrar.cc (right):
> 
>
https://codereview.chromium.org/756333003/diff/280001/chrome/browser/android/...
> chrome/browser/android/chrome_jni_registrar.cc:164: {"CardUnmaskPrompt",
> autofill::CardUnmaskPromptViewAndroid::Register},
> reorder this one now
> 
>
https://codereview.chromium.org/756333003/diff/280001/chrome/browser/ui/autof...
> File chrome/browser/ui/autofill/chrome_autofill_client.h (right):
> 
>
https://codereview.chromium.org/756333003/diff/280001/chrome/browser/ui/autof...
> chrome/browser/ui/autofill/chrome_autofill_client.h:30: class
> InstrumentUnmaskPromptView;
> delete?
> 
>
https://codereview.chromium.org/756333003/diff/280001/ui/android/java/res/lay...
> File ui/android/java/res/layout/autofill_card_unmask_prompt.xml (right):
> 
>
https://codereview.chromium.org/756333003/diff/280001/ui/android/java/res/lay...
> ui/android/java/res/layout/autofill_card_unmask_prompt.xml:25: <!--
> TODO(estade): make this a NumberPicker? -->
> I would remove this TODO as I don't think you'll ever want it to be.

aw lgtm.

[Evan Stade, 2014-12-10 23:46:21]

https://codereview.chromium.org/756333003/diff/280001/chrome/browser/android/...
File chrome/browser/android/chrome_jni_registrar.cc (right):

https://codereview.chromium.org/756333003/diff/280001/chrome/browser/android/...
chrome/browser/android/chrome_jni_registrar.cc:164: {"CardUnmaskPrompt",
autofill::CardUnmaskPromptViewAndroid::Register},
On 2014/12/10 22:04:59, Ted C wrote:
> reorder this one now

Done.

https://codereview.chromium.org/756333003/diff/280001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/chrome_autofill_client.h (right):

https://codereview.chromium.org/756333003/diff/280001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/chrome_autofill_client.h:30: class
InstrumentUnmaskPromptView;
On 2014/12/10 22:04:59, Ted C wrote:
> delete?

Done.

https://codereview.chromium.org/756333003/diff/280001/ui/android/java/res/lay...
File ui/android/java/res/layout/autofill_card_unmask_prompt.xml (right):

https://codereview.chromium.org/756333003/diff/280001/ui/android/java/res/lay...
ui/android/java/res/layout/autofill_card_unmask_prompt.xml:25: <!--
TODO(estade): make this a NumberPicker? -->
On 2014/12/10 22:04:59, Ted C wrote:
> I would remove this TODO as I don't think you'll ever want it to be.

Done.

[Evan Stade, 2014-12-10 23:46:26]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-12-10 23:48:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/756333003/300001

[commit-bot: I haz the power, 2014-12-10 23:53:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-10 23:53:59]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/92638)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Evan Stade, 2014-12-11 01:04:27]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-12-11 01:05:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/756333003/320001

[commit-bot: I haz the power, 2014-12-11 01:30:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-11 01:30:27]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/92681)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2014-12-11 02:07:18]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-12-11 02:09:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/756333003/340001

[commit-bot: I haz the power, 2014-12-11 03:53:39]

Committed patchset #18 (id:340001)

[commit-bot: I haz the power, 2014-12-11 03:54:29]

Patchset 18 (id:??) landed as
https://crrev.com/ecb659dff3cdc827b6228a61d05d0e3bb66cf969
Cr-Commit-Position: refs/heads/master@{#307854}