Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 756313002: Remove CSSCharsetRule (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-css, Inactive, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -352 lines) Patch
M LayoutTests/fast/dom/Window/resources/window-properties.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/css-element-attribute-js-null.html View 1 3 chunks +0 lines, -11 lines 0 comments Download
M LayoutTests/fast/dom/css-element-attribute-js-null-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/dom-constructors.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/dom-constructors-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/resources/wrapper-identity-base.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/wrapper-classes.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/wrapper-identity-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/encoding/css-charset-default.xhtml View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/encoding/css-charset-dom.html View 1 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/encoding/css-charset-dom-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/css/resources/shared-stylesheet-mutation.js View 1 2 chunks +18 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/css/shared-stylesheet-mutation-expected.txt View 1 16 chunks +0 lines, -16 lines 0 comments Download
M LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt View 1 16 chunks +0 lines, -16 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
D Source/core/css/CSSCharsetRule.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/core/css/CSSCharsetRule.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
D Source/core/css/CSSCharsetRule.idl View 1 chunk +0 lines, -23 lines 0 comments Download
M Source/core/css/CSSGroupingRule.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 3 chunks +3 lines, -20 lines 0 comments Download
M Source/core/css/StyleRule.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/StyleSheetContents.h View 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 7 chunks +21 lines, -66 lines 0 comments Download
M Source/core/css/parser/CSSGrammar.y View 1 chunk +2 lines, -16 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
philipj_slow
tests
6 years ago (2014-11-26 13:06:13 UTC) #1
philipj_slow
Rune, can you PTAL? The blink-dev thread as its 3 LGTMs.
6 years ago (2014-12-02 09:26:39 UTC) #3
rune
You didn't remove CHARSET_RULE from the CSSRule IDL, was that intentional?
6 years ago (2014-12-02 10:39:11 UTC) #4
philipj_slow
On 2014/12/02 10:39:11, rune wrote: > You didn't remove CHARSET_RULE from the CSSRule IDL, was ...
6 years ago (2014-12-02 11:03:05 UTC) #5
philipj_slow
The answer was "i guess leave it" in http://krijnhoetmer.nl/irc-logs/whatwg/20141202#l-243
6 years ago (2014-12-02 11:05:45 UTC) #6
rune
lgtm
6 years ago (2014-12-02 11:32:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756313002/20001
6 years ago (2014-12-02 12:04:40 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-02 12:07:00 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186292

Powered by Google App Engine
This is Rietveld 408576698