Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 756233002: Add more components unittests to the GN build. (Closed)

Created:
6 years ago by brettw
Modified:
6 years ago
Reviewers:
viettrungluu
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add more components unittests to the GN build. Add lots of missing dependencies identified by "gn check" in both the GN and GYP builds. Committed: https://crrev.com/462851f7ef02d8481a8225decfd940c8498b9485 Cr-Commit-Position: refs/heads/master@{#305841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -24 lines) Patch
M components/BUILD.gn View 1 chunk +12 lines, -14 lines 0 comments Download
M components/captive_portal/BUILD.gn View 3 chunks +5 lines, -2 lines 0 comments Download
M components/cloud_devices.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/cloud_devices/common/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/component_updater.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/component_updater/BUILD.gn View 3 chunks +8 lines, -1 line 0 comments Download
M components/crx_file/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/data_reduction_proxy.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 3 chunks +12 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/common/BUILD.gn View 2 chunks +15 lines, -3 lines 0 comments Download
M components/dom_distiller.gypi View 4 chunks +7 lines, -0 lines 0 comments Download
M components/dom_distiller/content/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/dom_distiller/core/BUILD.gn View 4 chunks +11 lines, -1 line 0 comments Download
M components/dom_distiller/webui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/domain_reliability/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/login/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics.gypi View 4 chunks +9 lines, -0 lines 0 comments Download
M components/metrics/BUILD.gn View 6 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
6 years ago (2014-11-26 01:02:00 UTC) #2
viettrungluu
lgtm
6 years ago (2014-11-26 01:13:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756233002/1
6 years ago (2014-11-26 17:59:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-26 18:39:04 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-26 18:39:53 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/462851f7ef02d8481a8225decfd940c8498b9485
Cr-Commit-Position: refs/heads/master@{#305841}

Powered by Google App Engine
This is Rietveld 408576698