Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 756203005: De-flake fast/multicol/split-in-top-margin.html (Closed)

Created:
6 years ago by mstensho (USE GERRIT)
Modified:
6 years ago
Reviewers:
dsinclair
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

De-flake fast/multicol/split-in-top-margin.html Cannot really trust Ahem. It behaves differently on different platforms. Set a line height instead, and bottom-align the inline-block, so that we don't have to worry about a descender of unpredictable height. Use regular blocks in the ref. Modified the second test slightly (reduce height by 1px), so that the line doesn't quite fit (which was typically the case before my changes, because of the descender, which by the way was assumed to be 3px in the test expectation). BUG=438757 R=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M LayoutTests/fast/multicol/split-in-top-margin.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/split-in-top-margin-expected.html View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
6 years ago (2014-12-03 22:40:43 UTC) #1
dsinclair
lgtm
6 years ago (2014-12-04 00:10:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756203005/1
6 years ago (2014-12-04 00:11:17 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-04 01:24:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186466

Powered by Google App Engine
This is Rietveld 408576698