Purge cache when the server removes the policy for an extension.

Purge cache when the server removes the policy for an extension.

Signed in users can get Chrome policies from a google service if their
account is managed. This service can also optionally send policy for
apps and extensions to the client.

This change fixes a glitch in the policy cache that prevented it from
purging old entries. If the policy for an extension is removed on the
server side then Chrome will now drop it from the cache.

BUG=435987
Committed: https://crrev.com/6d6c29093c59a971d635d477368179f5b023c4ec
Cr-Commit-Position: refs/heads/master@{#306171}

[Joao da Silva, 2014-11-25 17:07:15]

joaodasilva@chromium.org changed reviewers:
+ mnissler@chromium.org

[Joao da Silva, 2014-11-25 17:07:16]

Please have a look. Thanks!

[Mattias Nissler (ping if slow), 2014-11-26 13:44:14]

https://codereview.chromium.org/756133002/diff/20001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_client.h (right):

https://codereview.chromium.org/756133002/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client.h:205: // the server
didn't include a response.
Hm, this moves the responsibility to do the diffing on calling code. Can't we
just store NULL entries in the map returned by responses()?

Following up on the offline conversation: How about we pass the PolicyNamespace
set for extensions to the client and have the client reduce it to just a single
PolicyNamespace(EXTENSIONS, "") for the request? Then, we'd have all requested
namespaces present in ResponseMap, and a NULL indicates that the server didn't
provide a response.

After another discussion, there's the problem here that we'd all the namespaces
to be added before making the first fetch, which causes initialization
nightmares. Needs further thought.

[Joao da Silva, 2014-11-27 15:06:43]

Ready for another look. This has been rebased on
https://codereview.chromium.org/762863002.

The ComponentCloudPolicyService is now required to be created before the core
gets connected, so that we can make sure the policy fetch types are all in place
at the right time.

FWIW, there is an observer of OnCoreConnected that will start a fetch
(user_cloud_policy_manager_chromeos.cc).

I think this is an improvement though I don't like passing the core & the client
separately in the constructor of ComponentCloudPolicyService. If you think
that's worth cleaning up too then I guess we could make the core notify its
observers with a new call e.g. OnCorePreConnect(). WDYT?

[Mattias Nissler (ping if slow), 2014-11-28 14:19:05]

LGTM w/ nits.

https://codereview.chromium.org/756133002/diff/60001/components/policy/core/c...
File components/policy/core/common/cloud/component_cloud_policy_service.cc
(right):

https://codereview.chromium.org/756133002/diff/60001/components/policy/core/c...
components/policy/core/common/cloud/component_cloud_policy_service.cc:86: //
Passes a vector with all the PolicyFetchResponses currently set at the
not a vector

https://codereview.chromium.org/756133002/diff/60001/components/policy/core/c...
File
components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
(right):

https://codereview.chromium.org/756133002/diff/60001/components/policy/core/c...
components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc:424:
// Now signin. The service will finish loadings its backend (which is empty
s/loadings/loading/

[Joao da Silva, 2014-11-28 15:16:39]

Thanks for the reviews!

https://codereview.chromium.org/756133002/diff/60001/components/policy/core/c...
File components/policy/core/common/cloud/component_cloud_policy_service.cc
(right):

https://codereview.chromium.org/756133002/diff/60001/components/policy/core/c...
components/policy/core/common/cloud/component_cloud_policy_service.cc:86: //
Passes a vector with all the PolicyFetchResponses currently set at the
On 2014/11/28 14:19:05, Mattias Nissler wrote:
> not a vector

Done.

https://codereview.chromium.org/756133002/diff/60001/components/policy/core/c...
File
components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
(right):

https://codereview.chromium.org/756133002/diff/60001/components/policy/core/c...
components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc:424:
// Now signin. The service will finish loadings its backend (which is empty
On 2014/11/28 14:19:05, Mattias Nissler wrote:
> s/loadings/loading/

Done.

[Joao da Silva, 2014-11-28 15:16:54]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2014-11-28 15:17:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/756133002/80001

[commit-bot: I haz the power, 2014-11-28 15:23:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-28 15:23:09]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Joao da Silva, 2014-11-28 15:33:35]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2014-11-28 15:34:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/756133002/90001

[commit-bot: I haz the power, 2014-11-28 15:55:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-28 15:55:14]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Joao da Silva, 2014-12-01 10:31:58]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2014-12-01 10:32:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/756133002/130001

[commit-bot: I haz the power, 2014-12-01 11:15:38]

Committed patchset #8 (id:130001)

[commit-bot: I haz the power, 2014-12-01 11:16:27]

Patchset 8 (id:??) landed as
https://crrev.com/6d6c29093c59a971d635d477368179f5b023c4ec
Cr-Commit-Position: refs/heads/master@{#306171}