Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 756033003: Expose IA2 role for embed, object element. (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Expose IA2 role for embed, object element. Embed/object elements should have MSAA/IAccessible2 role as IA2_ROLE_EMBEDDED_OBJECT. BUG=348259 Committed: https://crrev.com/567c4addda8e2e4f7c916ce825b779225a372d84 Cr-Commit-Position: refs/heads/master@{#305843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/embed.html View 1 chunk +8 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/embed-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/embed-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/embed-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/object-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!!
6 years ago (2014-11-26 12:05:50 UTC) #2
dmazzoni
lgtm
6 years ago (2014-11-26 17:46:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756033003/1
6 years ago (2014-11-26 17:47:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-26 18:46:37 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-26 18:47:21 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/567c4addda8e2e4f7c916ce825b779225a372d84
Cr-Commit-Position: refs/heads/master@{#305843}

Powered by Google App Engine
This is Rietveld 408576698