Revert of "Remove SSLClientAuthHandler's RDH dependency." (https://codereview.chromium.org/59687300…

Revert of "Remove SSLClientAuthHandler's RDH dependency." (https://codereview.chromium.org/596873002)

Reason for revert:
Causes browser crash if URL request is cancelled during client cert loading.

BUG=422765, 427844, 376003
TBR=davidben@chromium.org

Committed: https://crrev.com/e18bf1d9005b08bba3637b16d744245e5467af0e
Cr-Commit-Position: refs/heads/master@{#305707}

[pneubeck (no reviews), 2014-11-25 16:13:43]

pneubeck@chromium.org changed reviewers:
+ pneubeck@chromium.org

[pneubeck (no reviews), 2014-11-25 16:13:43]

Just discussed shortly with Ryan. If this revert reduces the number of crashes,
we should do so and afterwards can look for a fix of the lifetime issue that we
seem to have in ClientCertStore.

[mattm, 2014-11-25 21:25:42]

mattm@chromium.org changed reviewers:
+ davidben@chromium.org

[mattm, 2014-11-25 21:27:22]

Ok, going to land the revert. TBRing to David.

[mattm, 2014-11-25 21:27:35]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2014-11-25 21:28:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755933002/20001

[commit-bot: I haz the power, 2014-11-25 22:33:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-25 22:34:30]

Patchset 2 (id:??) landed as
https://crrev.com/e18bf1d9005b08bba3637b16d744245e5467af0e
Cr-Commit-Position: refs/heads/master@{#305707}

[robliao, 2014-11-26 17:59:28]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/750633005/ by robliao@chromium.org.

The reason for reverting is: Leak in SSLUITestWithClientCert.TestWSSClientCert

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...

First reported leak:
Indirect leak of 104 byte(s) in 1 object(s) allocated from:
    #0 0x57659b in operator new(unsigned long)
(/tmp/run_tha_test0QXqvt/out/Release/browser_tests+0x57659b)
    #1 0x2c7762d in ProfileIOData::ResourceContext::CreateClientCertStore()
chrome/browser/profiles/profile_io_data.cc:920:7
    #2 0x6c908bd in
content::ResourceLoader::OnCertificateRequested(net::URLRequest*,
net::SSLCertRequestInfo*) content/browser/loader/resource_loader.cc:298:7
    #3 0x3e3e15f in
net::URLRequest::NotifyCertificateRequested(net::SSLCertRequestInfo*)
net/url_request/url_request.cc:1109:5
    #4 0x405ea0d in net::URLRequestHttpJob::OnStartCompleted(int)
net/url_request/url_request_http_job.cc:925:5
    #5 0x3ccd86c in Run base/callback.h:396:12
    #6 0x3ccd86c in net::HttpCache::Transaction::DoCallback(int)
net/http/http_cache_transaction.cc:710
    #7 0x3cca160 in HandleResult net/http/http_cache_transaction.cc:716:5
    #8 0x3cca160 in net::HttpCache::Transaction::DoLoop(int)
net/http/http_cache_transaction.cc:977
    #9 0x3cc7a68 in net::HttpCache::Transaction::OnIOComplete(int)
net/http/http_cache_transaction.cc:2934:3
    #10 0xc78765a in Run base/callback.h:396:12
    #11 0xc78765a in DevToolsNetworkTransaction::OnCallback(int)
chrome/browser/devtools/devtools_network_transaction.cc:73
    #12 0x3ceab0c in Run base/callback.h:396:12
    #13 0x3ceab0c in DoCallback net/http/http_network_transaction.cc:577
    #14 0x3ceab0c in net::HttpNetworkTransaction::OnIOComplete(int)
net/http/http_network_transaction.cc:594
    #15 0x394b58f in Run base/callback.h:396:12
    #16 0x394b58f in base::debug::TaskAnnotator::RunTask(char const*, char
const*, base::PendingTask const&) base/debug/task_annotator.cc:63
    #17 0x388dd3c in base::MessageLoop::RunTask(base::PendingTask const&)
base/message_loop/message_loop.cc:448:3
    #18 0x388e49b in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask
const&) base/message_loop/message_loop.cc:458:5
    #19 0x388ef57 in base::MessageLoop::DoWork()
base/message_loop/message_loop.cc:567:13
    #20 0x3932db7 in
base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)
base/message_loop/message_pump_libevent.cc:232:21
    #21 0x38c0c1c in base::RunLoop::Run() base/run_loop.cc:55:3
    #22 0x388c843 in base::MessageLoop::Run()
base/message_loop/message_loop.cc:310:3
    #23 0x6af33c1 in content::BrowserThreadImpl::IOThreadRun(base::MessageLoop*)
content/browser/browser_thread_impl.cc:218:3
    #24 0x6af375e in content::BrowserThreadImpl::Run(base::MessageLoop*)
content/browser/browser_thread_impl.cc:253:14
    #25 0x390cec1 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
    #26 0x3901e17 in base::(anonymous namespace)::ThreadFunc(void*)
base/threading/platform_thread_posix.cc:80:3
    #27 0x7f99b0016e99 in start_thread
/build/buildd/eglibc-2.15/nptl/pthread_create.c:308.