Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 755883003: Refactor use of Isolate::use_crankshaft. (Closed)

Created:
6 years ago by Yang
Modified:
6 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Refactor use of Isolate::use_crankshaft. R=jkummerow@chromium.org

Patch Set 1 #

Patch Set 2 : remove bogus assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -24 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 3 chunks +4 lines, -19 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yang
6 years ago (2014-11-25 08:48:00 UTC) #1
Jakob Kummerow
lgtm
6 years ago (2014-11-25 10:49:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755883003/1
6 years ago (2014-11-25 11:18:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/1388)
6 years ago (2014-11-25 12:14:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755883003/20001
6 years ago (2014-11-25 12:19:11 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-25 12:46:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698