Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 755753002: Update ninja to v1.5.3 on Mac, Linux32, Linux64, Windows. (Closed)

Created:
6 years ago by Nico
Modified:
6 years ago
Reviewers:
M-A Ruel, scottmg
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Update ninja to v1.5.3 on Mac, Linux32, Linux64, Windows. See the bug for how these were built. The linux binaries were built by thestig@chromium.org. The windows binary was built by scottmg@chromium.org. The mac binary was built by thakis@chromium.org BUG=436109 TBR=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293084

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M depot_tools/ninja View 1 1 chunk +2 lines, -2 lines 0 comments Download
M depot_tools/ninja.exe View Binary file 0 comments Download
M depot_tools/ninja-linux32 View Binary file 0 comments Download
M depot_tools/ninja-linux64 View Binary file 0 comments Download
M depot_tools/ninja-mac View Binary file 0 comments Download

Messages

Total messages: 9 (2 generated)
Nico
6 years ago (2014-11-24 21:02:44 UTC) #2
scottmg
lgtm
6 years ago (2014-11-24 21:07:20 UTC) #3
scottmg
https://codereview.chromium.org/755753002/diff/1/depot_tools/ninja File depot_tools/ninja (right): https://codereview.chromium.org/755753002/diff/1/depot_tools/ninja#newcode16 depot_tools/ninja:16: ./ninja/bootstrap.py this could use an update i guess
6 years ago (2014-11-24 21:07:48 UTC) #4
Nico
https://codereview.chromium.org/755753002/diff/1/depot_tools/ninja File depot_tools/ninja (right): https://codereview.chromium.org/755753002/diff/1/depot_tools/ninja#newcode16 depot_tools/ninja:16: ./ninja/bootstrap.py On 2014/11/24 21:07:48, scottmg wrote: > this could ...
6 years ago (2014-11-24 21:10:48 UTC) #5
Nico
On 2014/11/24 21:10:48, Nico wrote: > https://codereview.chromium.org/755753002/diff/1/depot_tools/ninja > File depot_tools/ninja (right): > > https://codereview.chromium.org/755753002/diff/1/depot_tools/ninja#newcode16 > ...
6 years ago (2014-11-24 21:14:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755753002/20001
6 years ago (2014-11-24 21:16:58 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-24 21:19:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293084

Powered by Google App Engine
This is Rietveld 408576698