content/browser/permissions/permission_service_impl.cc - Issue 755673002: Update MidiDispatcher to use Mojo Permission Service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/permissions/permission_service_impl.cc

Issue 755673002: Update MidiDispatcher to use Mojo Permission Service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/midi_dispatcher_host.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | content/common/permission_service.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/permissions/permission_service_impl.cc

diff --git a/content/browser/permissions/permission_service_impl.cc b/content/browser/permissions/permission_service_impl.cc

index a5f66bf2f54790a6b89d835636d2cffe7a5eb759..58496a46e9c01c97ce5ba6b45c5314d6cbe13b04 100644

--- a/content/browser/permissions/permission_service_impl.cc

+++ b/content/browser/permissions/permission_service_impl.cc

@@ -16,6 +16,8 @@ PermissionType PermissionNameToPermissionType(PermissionName name) {

switch(name) {

case PERMISSION_NAME_GEOLOCATION:

return PERMISSION_GEOLOCATION;

+ case PERMISSION_NAME_MIDI_SYSEX:

+ return PERMISSION_MIDI_SYSEX;

}

NOTREACHED();

@@ -82,6 +84,7 @@ void PermissionServiceImpl::OnRequestPermissionResponse(

int request_id,

bool allowed) {

// TODO(mlamouri): we might want a generic way to handle those things.

+ // TODO(mlamouri): could that move to <name>_permission_context.cc?

if (allowed &&

pending_requests_.Lookup(request_id)->permission ==

PERMISSION_GEOLOCATION) {