Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 755653006: Instrumented libraries: do not use FORTIFY_SOURCE when building udev. (Closed)

Created:
6 years ago by earthdok
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: do not use FORTIFY_SOURCE when building udev. Also, address a nit from a prior post-commit review. BUG=414189 TBR=glider@chromium.org NOTRY=true Committed: https://crrev.com/ea75a9de16c6f45d6ce4a7ce3e1bbf8e0070c0ae Cr-Commit-Position: refs/heads/master@{#306897}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/instrumented_libraries/download_build_install.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/instrumented_libraries/scripts/udev.sh View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
earthdok
6 years ago (2014-12-04 21:32:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755653006/40001
6 years ago (2014-12-04 21:39:25 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-04 21:40:17 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ea75a9de16c6f45d6ce4a7ce3e1bbf8e0070c0ae Cr-Commit-Position: refs/heads/master@{#306897}
6 years ago (2014-12-04 21:41:01 UTC) #7
Alexander Potapenko
6 years ago (2014-12-05 10:01:17 UTC) #8
Message was sent while issue was closed.
On 2014/12/04 21:41:01, I haz the power (commit-bot) wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/ea75a9de16c6f45d6ce4a7ce3e1bbf8e0070c0ae
> Cr-Commit-Position: refs/heads/master@{#306897}

LGTM

Powered by Google App Engine
This is Rietveld 408576698