Replace SystemUIResourceManager with ResourceManager

ui/android/resources/resource_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_ANDROID_RESOURCES_RESOURCE_MANAGER_H_
 #define UI_ANDROID_RESOURCES_RESOURCE_MANAGER_H_
 
+#include <string>
+
 #include "base/android/jni_android.h"
 #include "base/id_map.h"
 #include "cc/resources/ui_resource_client.h"
 #include "ui/android/ui_android_export.h"
+#include "ui/base/android/system_ui_resource_type.h"
 #include "ui/gfx/geometry/rect.h"
 
-namespace content {
-class UIResourceProvider;
-}
-
 namespace ui {
 
 class UIResourceAndroid;
+class UIResourceProvider;
 
 // A Java counterpart will be generated for this enum.
 // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.ui.resources
 enum AndroidResourceType {
   ANDROID_RESOURCE_TYPE_STATIC = 0,
   ANDROID_RESOURCE_TYPE_DYNAMIC,
   ANDROID_RESOURCE_TYPE_DYNAMIC_BITMAP,
   ANDROID_RESOURCE_TYPE_SYSTEM,
 
   ANDROID_RESOURCE_TYPE_COUNT,
@@ skipping 11 matching lines @@
     gfx::Rect Border(const gfx::Size& bounds, const gfx::InsetsF& scale);
 
     scoped_ptr<UIResourceAndroid> ui_resource;
     gfx::Size size;
     gfx::Rect padding;
     gfx::Rect aperture;
   };
 
   static ResourceManager* FromJavaObject(jobject jobj);
 
-  explicit ResourceManager(content::UIResourceProvider* ui_resource_provider);
+  explicit ResourceManager(ui::UIResourceProvider* ui_resource_provider);
   virtual ~ResourceManager();
 
   base::android::ScopedJavaLocalRef<jobject> GetJavaObject(JNIEnv* env);
 
+  virtual void PreloadResource(ui::SystemUIResourceType type);

[jdduke (slow), 2014/12/10 01:46:41]

Let's go ahead and remove these two methods, updating the callers to use the new
Preload/Get API.

[Jaekyun Seok (inactive), 2014/12/10 02:25:41]

I believe that GetUIResourceId is useful and so I will keep it after changing it
to get res_type and res_id as parameters.

+  virtual cc::UIResourceId GetUIResourceId(ui::SystemUIResourceType type);
+
   ResourceManager::Resource* GetResource(AndroidResourceType res_type,
                                          int res_id);
+  ResourceManager::Resource* GetResource(AndroidResourceType res_type,

[jdduke (slow), 2014/12/10 01:46:41]

I'm wary of adding these methods that take a string without having any existing
users. Could we add them later? 

In any case, please avoid passing std::string by value. Either pass by const
ref, or pass a const char* (or a StringPiece).

[Jaekyun Seok (inactive), 2014/12/10 02:25:41]

I agree. Let's do this later when it is needed.

+                                         std::string res_name);
   void PreloadResource(AndroidResourceType res_type, int res_id);
+  void PreloadResource(AndroidResourceType res_type, std::string res_name);
 
   // Called from Java ----------------------------------------------------------
   void OnResourceReady(JNIEnv* env,
                        jobject jobj,
                        jint res_type,
                        jint res_id,
                        jobject bitmap,
                        jint padding_left,
                        jint padding_top,
                        jint padding_right,
                        jint padding_bottom,
                        jint aperture_left,
                        jint aperture_top,
                        jint aperture_right,
                        jint aperture_bottom);
 
   static bool RegisterResourceManager(JNIEnv* env);
 
  private:
+  friend class TestResourceManager;
+
+  int GetAndroidResourceIdFromString(std::string res_name);
+
+  // Start loading the resource. virtual for testing.
+  virtual void PreloadResourceFromJava(AndroidResourceType res_type,
+                                       int res_id);
+  virtual void RequestResourceFromJava(AndroidResourceType res_type,
+                                       int res_id);
+
   typedef IDMap<Resource, IDMapOwnPointer> ResourceMap;
 
-  content::UIResourceProvider* ui_resource_provider_;
+  ui::UIResourceProvider* ui_resource_provider_;
   ResourceMap resources_[ANDROID_RESOURCE_TYPE_COUNT];
 
   base::android::ScopedJavaGlobalRef<jobject> java_obj_;
+  base::hash_map<std::string, int> android_res_name_to_res_id_map_;
 
   DISALLOW_COPY_AND_ASSIGN(ResourceManager);
 };
 
 }  // namespace ui
 
 #endif  // UI_ANDROID_RESOURCES_RESOURCE_MANAGER_H_