Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: ui/android/resources/resource_manager_unittest.cc

Issue 755643004: Replace SystemUIResourceManager with ResourceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unittest Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/ui_resource_bitmap.h" 5 #include "cc/resources/ui_resource_bitmap.h"
6 #include "content/browser/android/system_ui_resource_manager_impl.h"
7 #include "content/public/browser/android/ui_resource_client_android.h"
8 #include "content/public/browser/android/ui_resource_provider.h"
9 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
10 #include "third_party/skia/include/core/SkBitmap.h" 7 #include "third_party/skia/include/core/SkBitmap.h"
11 #include "third_party/skia/include/core/SkCanvas.h" 8 #include "third_party/skia/include/core/SkCanvas.h"
9 #include "ui/android/resources/resource_manager.h"
10 #include "ui/android/resources/ui_resource_client_android.h"
11 #include "ui/android/resources/ui_resource_provider.h"
12 #include "ui/gfx/android/java_bitmap.h"
12 13
13 namespace content { 14 namespace ui {
14 15
15 class TestSystemUIResourceManagerImpl 16 class TestResourceManager : public ResourceManager {
16 : public content::SystemUIResourceManagerImpl {
17 public: 17 public:
18 TestSystemUIResourceManagerImpl(content::UIResourceProvider* provider) 18 TestResourceManager(UIResourceProvider* provider)
19 : SystemUIResourceManagerImpl(provider) {} 19 : ResourceManager(provider) {}
20 20
21 virtual ~TestSystemUIResourceManagerImpl() {} 21 virtual ~TestResourceManager() {}
22 22
23 virtual void BuildResource(ui::SystemUIResourceType type) override {} 23 virtual void PreloadResourceFromJava(AndroidResourceType res_type,
24 int res_id) override {}
24 25
25 void SetResourceAsLoaded(ui::SystemUIResourceType type) { 26 virtual void RequestResourceFromJava(AndroidResourceType res_type,
27 int res_id) override {}
28
29 void SetResourceAsLoaded(AndroidResourceType res_type, int res_id) {
26 SkBitmap small_bitmap; 30 SkBitmap small_bitmap;
27 SkCanvas canvas(small_bitmap); 31 SkCanvas canvas(small_bitmap);
28 small_bitmap.allocPixels( 32 small_bitmap.allocPixels(
29 SkImageInfo::Make(1, 1, kRGBA_8888_SkColorType, kOpaque_SkAlphaType)); 33 SkImageInfo::Make(1, 1, kRGBA_8888_SkColorType, kOpaque_SkAlphaType));
30 canvas.drawColor(SK_ColorWHITE); 34 canvas.drawColor(SK_ColorWHITE);
31 small_bitmap.setImmutable(); 35 small_bitmap.setImmutable();
32 OnFinishedLoadBitmap(type, &small_bitmap); 36
37 OnResourceReady(NULL, NULL, res_type, res_id,
38 gfx::ConvertToJavaBitmap(&small_bitmap).obj(), 0, 0, 0, 0,
39 0, 0, 0, 0);
33 } 40 }
34 }; 41 };
35 42
36 namespace { 43 namespace {
37 44
38 const ui::SystemUIResourceType kTestResourceType = ui::OVERSCROLL_GLOW; 45 const ui::SystemUIResourceType kTestResourceType = ui::OVERSCROLL_GLOW;
39 46
40 class MockUIResourceProvider : public content::UIResourceProvider { 47 class MockUIResourceProvider : public ui::UIResourceProvider {
41 public: 48 public:
42 MockUIResourceProvider() 49 MockUIResourceProvider()
43 : next_ui_resource_id_(1), 50 : next_ui_resource_id_(1),
44 has_layer_tree_host_(true), 51 has_layer_tree_host_(true),
45 system_ui_resource_manager_(this) {} 52 resource_manager_(this) {}
46 53
47 virtual ~MockUIResourceProvider() {} 54 virtual ~MockUIResourceProvider() {}
48 55
49 virtual cc::UIResourceId CreateUIResource( 56 virtual cc::UIResourceId CreateUIResource(
50 content::UIResourceClientAndroid* client) override { 57 ui::UIResourceClientAndroid* client) override {
51 if (!has_layer_tree_host_) 58 if (!has_layer_tree_host_)
52 return 0; 59 return 0;
53 cc::UIResourceId id = next_ui_resource_id_++; 60 cc::UIResourceId id = next_ui_resource_id_++;
54 client->GetBitmap(id, false); 61 client->GetBitmap(id, false);
55 ui_resource_client_map_[id] = client; 62 ui_resource_client_map_[id] = client;
56 return id; 63 return id;
57 } 64 }
58 65
59 virtual void DeleteUIResource(cc::UIResourceId id) override { 66 virtual void DeleteUIResource(cc::UIResourceId id) override {
60 CHECK(has_layer_tree_host_); 67 CHECK(has_layer_tree_host_);
61 ui_resource_client_map_.erase(id); 68 ui_resource_client_map_.erase(id);
62 } 69 }
63 70
64 virtual bool SupportsETC1NonPowerOfTwo() const override { return true; } 71 virtual bool SupportsETC1NonPowerOfTwo() const override { return true; }
65 72
66 void LayerTreeHostCleared() { 73 void LayerTreeHostCleared() {
67 has_layer_tree_host_ = false; 74 has_layer_tree_host_ = false;
68 UIResourceClientMap client_map = ui_resource_client_map_; 75 UIResourceClientMap client_map = ui_resource_client_map_;
69 ui_resource_client_map_.clear(); 76 ui_resource_client_map_.clear();
70 for (UIResourceClientMap::iterator iter = client_map.begin(); 77 for (UIResourceClientMap::iterator iter = client_map.begin();
71 iter != client_map.end(); 78 iter != client_map.end(); iter++) {
72 iter++) {
73 iter->second->UIResourceIsInvalid(); 79 iter->second->UIResourceIsInvalid();
74 } 80 }
75 } 81 }
76 82
77 void LayerTreeHostReturned() { has_layer_tree_host_ = true; } 83 void LayerTreeHostReturned() { has_layer_tree_host_ = true; }
78 84
79 TestSystemUIResourceManagerImpl& GetSystemUIResourceManager() { 85 TestResourceManager& GetResourceManager() { return resource_manager_; }
80 return system_ui_resource_manager_;
81 }
82 86
83 cc::UIResourceId next_ui_resource_id() const { return next_ui_resource_id_; } 87 cc::UIResourceId next_ui_resource_id() const { return next_ui_resource_id_; }
84 88
85 private: 89 private:
86 typedef base::hash_map<cc::UIResourceId, content::UIResourceClientAndroid*> 90 typedef base::hash_map<cc::UIResourceId, ui::UIResourceClientAndroid*>
87 UIResourceClientMap; 91 UIResourceClientMap;
88 92
89 cc::UIResourceId next_ui_resource_id_; 93 cc::UIResourceId next_ui_resource_id_;
90 UIResourceClientMap ui_resource_client_map_; 94 UIResourceClientMap ui_resource_client_map_;
91 bool has_layer_tree_host_; 95 bool has_layer_tree_host_;
92 96
93 // The UIResourceProvider owns the SystemUIResourceManager. 97 // The UIResourceProvider owns the ResourceManager.
94 TestSystemUIResourceManagerImpl system_ui_resource_manager_; 98 TestResourceManager resource_manager_;
95 }; 99 };
96 100
97 } // namespace 101 } // namespace
98 102
99 class SystemUIResourceManagerImplTest : public testing::Test { 103 class ResourceManagerTest : public testing::Test {
100 public: 104 public:
101 void PreloadResource(ui::SystemUIResourceType type) { 105 void PreloadResource(ui::SystemUIResourceType type) {
102 ui_resource_provider_.GetSystemUIResourceManager().PreloadResource(type); 106 ui_resource_provider_.GetResourceManager().PreloadResource(type);
103 } 107 }
104 108
105 cc::UIResourceId GetUIResourceId(ui::SystemUIResourceType type) { 109 cc::UIResourceId GetUIResourceId(ui::SystemUIResourceType type) {
106 return ui_resource_provider_.GetSystemUIResourceManager().GetUIResourceId( 110 return ui_resource_provider_.GetResourceManager().GetUIResourceId(type);
107 type);
108 } 111 }
109 112
110 void LayerTreeHostCleared() { ui_resource_provider_.LayerTreeHostCleared(); } 113 void LayerTreeHostCleared() { ui_resource_provider_.LayerTreeHostCleared(); }
111 114
112 void LayerTreeHostReturned() { 115 void LayerTreeHostReturned() {
113 ui_resource_provider_.LayerTreeHostReturned(); 116 ui_resource_provider_.LayerTreeHostReturned();
114 } 117 }
115 118
116 void SetResourceAsLoaded(ui::SystemUIResourceType type) { 119 void SetResourceAsLoaded(ui::SystemUIResourceType type) {
117 ui_resource_provider_.GetSystemUIResourceManager().SetResourceAsLoaded( 120 ui_resource_provider_.GetResourceManager().SetResourceAsLoaded(
118 type); 121 ui::ANDROID_RESOURCE_TYPE_SYSTEM, type);
119 } 122 }
120 123
121 cc::UIResourceId GetNextUIResourceId() const { 124 cc::UIResourceId GetNextUIResourceId() const {
122 return ui_resource_provider_.next_ui_resource_id(); 125 return ui_resource_provider_.next_ui_resource_id();
123 } 126 }
124 127
125 private: 128 private:
126 MockUIResourceProvider ui_resource_provider_; 129 MockUIResourceProvider ui_resource_provider_;
127 }; 130 };
128 131
129 TEST_F(SystemUIResourceManagerImplTest, GetResourceAfterBitmapLoaded) { 132 TEST_F(ResourceManagerTest, GetResourceAfterBitmapLoaded) {
130 SetResourceAsLoaded(kTestResourceType); 133 SetResourceAsLoaded(kTestResourceType);
131 EXPECT_NE(0, GetUIResourceId(kTestResourceType)); 134 EXPECT_NE(0, GetUIResourceId(kTestResourceType));
132 } 135 }
133 136
134 TEST_F(SystemUIResourceManagerImplTest, GetResourceBeforeLoadBitmap) { 137 TEST_F(ResourceManagerTest, GetResourceBeforeLoadBitmap) {
135 EXPECT_EQ(0, GetUIResourceId(kTestResourceType)); 138 EXPECT_EQ(0, GetUIResourceId(kTestResourceType));
136 SetResourceAsLoaded(kTestResourceType); 139 SetResourceAsLoaded(kTestResourceType);
137 EXPECT_NE(0, GetUIResourceId(kTestResourceType)); 140 EXPECT_NE(0, GetUIResourceId(kTestResourceType));
138 } 141 }
139 142
140 TEST_F(SystemUIResourceManagerImplTest, PreloadEnsureResource) { 143 TEST_F(ResourceManagerTest, PreloadEnsureResource) {
141 // Preloading the resource should trigger bitmap loading, but the actual 144 // Preloading the resource should trigger bitmap loading, but the actual
142 // resource id will not be generated until it is explicitly requested. 145 // resource id will not be generated until it is explicitly requested.
143 cc::UIResourceId first_resource_id = GetNextUIResourceId(); 146 cc::UIResourceId first_resource_id = GetNextUIResourceId();
144 PreloadResource(kTestResourceType); 147 PreloadResource(kTestResourceType);
145 SetResourceAsLoaded(kTestResourceType); 148 SetResourceAsLoaded(kTestResourceType);
146 EXPECT_EQ(first_resource_id, GetNextUIResourceId()); 149 EXPECT_EQ(first_resource_id, GetNextUIResourceId());
147 EXPECT_NE(0, GetUIResourceId(kTestResourceType)); 150 EXPECT_NE(0, GetUIResourceId(kTestResourceType));
148 EXPECT_NE(first_resource_id, GetNextUIResourceId()); 151 EXPECT_NE(first_resource_id, GetNextUIResourceId());
149 } 152 }
150 153
151 TEST_F(SystemUIResourceManagerImplTest, ResetLayerTreeHost) { 154 TEST_F(ResourceManagerTest, ResetLayerTreeHost) {
152 EXPECT_EQ(0, GetUIResourceId(kTestResourceType)); 155 EXPECT_EQ(0, GetUIResourceId(kTestResourceType));
153 LayerTreeHostCleared(); 156 LayerTreeHostCleared();
154 EXPECT_EQ(0, GetUIResourceId(kTestResourceType)); 157 EXPECT_EQ(0, GetUIResourceId(kTestResourceType));
155 LayerTreeHostReturned(); 158 LayerTreeHostReturned();
156 EXPECT_EQ(0, GetUIResourceId(kTestResourceType)); 159 EXPECT_EQ(0, GetUIResourceId(kTestResourceType));
157 160
158 SetResourceAsLoaded(kTestResourceType); 161 SetResourceAsLoaded(kTestResourceType);
159 EXPECT_NE(0, GetUIResourceId(kTestResourceType)); 162 EXPECT_NE(0, GetUIResourceId(kTestResourceType));
160 LayerTreeHostCleared(); 163 LayerTreeHostCleared();
161 EXPECT_EQ(0, GetUIResourceId(kTestResourceType)); 164 EXPECT_EQ(0, GetUIResourceId(kTestResourceType));
162 LayerTreeHostReturned(); 165 LayerTreeHostReturned();
163 EXPECT_NE(0, GetUIResourceId(kTestResourceType)); 166 EXPECT_NE(0, GetUIResourceId(kTestResourceType));
164 } 167 }
165 168
166 } // namespace content 169 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698