Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: src/typing.cc

Issue 755513003: Hydrogen: fix keyed loads with string keys (Closed) Base URL: gh:v8/v8@master
Patch Set: fixes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/typing.cc
diff --git a/src/typing.cc b/src/typing.cc
index 1cfaf64f64a403e4a44b035c889c091625ac0592..5376309d69d71b931d0b9a906c29816c853c796f 100644
--- a/src/typing.cc
+++ b/src/typing.cc
@@ -494,9 +494,11 @@ void AstTyper::VisitProperty(Property* expr) {
oracle()->PropertyReceiverTypes(id, name, expr->GetReceiverTypes());
} else {
bool is_string;
+ IcCheckType key_type;
oracle()->KeyedPropertyReceiverTypes(
- id, expr->GetReceiverTypes(), &is_string);
+ id, expr->GetReceiverTypes(), &is_string, &key_type);
expr->set_is_string_access(is_string);
+ expr->set_key_type(key_type);
}
}

Powered by Google App Engine
This is Rietveld 408576698