src/hydrogen.cc - Issue 755513003: Hydrogen: fix keyed loads with string keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 755513003: Hydrogen: fix keyed loads with string keys (Closed) Base URL: gh:v8/v8@master

Patch Set: better fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 834af7245ff295166935394cdaa6411bfbdea052..d5c8ea6e65d27ba459dec6db50bb5a1981198848 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -7240,7 +7240,7 @@ HValue* HOptimizedGraphBuilder::HandleKeyedElementAccess(

bool monomorphic = ComputeReceiverTypes(expr, obj, &types, zone());

bool force_generic = false;

- if (access_type == STORE && expr->GetKeyType() == PROPERTY) {

+ if (expr->GetKeyType() == PROPERTY) {

// Non-Generic accesses assume that elements are being accessed, and will

// deopt for non-index keys, which the IC knows will occur.

// TODO(jkummerow): Consider adding proper support for property accesses.